From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH V4 11/24] libxl/gentypes.py: include
 discriminator in JSON output
Date: Tue, 6 May 2014 14:09:13 +0100
Message-ID: <20140506130913.GG17067@zion.uk.xensource.com>
References: <1398949101-23320-1-git-send-email-wei.liu2@citrix.com>
	<1398949101-23320-12-git-send-email-wei.liu2@citrix.com>
	<1399381429.3014.124.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1399381429.3014.124.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: ian.jackson@eu.citrix.com, Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, May 06, 2014 at 02:03:49PM +0100, Ian Campbell wrote:
> On Thu, 2014-05-01 at 13:58 +0100, Wei Liu wrote:
> > Parser relies on the discriminator to go to correct branch.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> 
> Acked-by: Ian Campbell <ian.campbell@citrix>
> 
> But, an idea: What about calling the field which refers to the union by
> it's discriminated name, i.e. "u.pv": { map of things } instead of
> "type": "pv", "u" { map of things } ?
> 
> 

But that breaks API, doesn't it? If we can safely assume that there's no
existing user of this JSON API, changing it won't be hard.

Wei.