From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Sipek Subject: Re: [GUILT 04/28] Allow "guilt import-commit" to run from a dir which contains spaces. Date: Tue, 6 May 2014 14:27:38 -0400 Message-ID: <20140506182738.GI1655@meili.valhalla.31bits.net> References: <1395387126-13681-1-git-send-email-cederp@opera.com> <1395387126-13681-5-git-send-email-cederp@opera.com> <20140323170409.GG1661@meili.valhalla.31bits.net> <20140323200739.GJ1661@meili.valhalla.31bits.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: git@vger.kernel.org To: Per Cederqvist X-From: git-owner@vger.kernel.org Tue May 06 22:11:32 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WhkCI-0002bK-Sk for gcvg-git-2@plane.gmane.org; Tue, 06 May 2014 20:34:35 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751718AbaEFSeb (ORCPT ); Tue, 6 May 2014 14:34:31 -0400 Received: from josefsipek.net ([64.9.206.49]:1628 "EHLO josefsipek.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750859AbaEFSea (ORCPT ); Tue, 6 May 2014 14:34:30 -0400 X-Greylist: delayed 415 seconds by postgrey-1.27 at vger.kernel.org; Tue, 06 May 2014 14:34:30 EDT Received: from meili.valhalla.31bits.net (c-98-209-117-250.hsd1.mi.comcast.net [98.209.117.250]) by josefsipek.net (Postfix) with ESMTPSA id 8CC1055659; Tue, 6 May 2014 14:27:34 -0400 (EDT) Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Sun, Mar 23, 2014 at 10:13:53PM +0100, Per Cederqvist wrote: > On Sun, Mar 23, 2014 at 9:07 PM, Jeff Sipek wrote: > > On Sun, Mar 23, 2014 at 08:57:08PM +0100, Per Cederqvist wrote: > >> On Sun, Mar 23, 2014 at 6:04 PM, Jeff Sipek wrote: > >> > >> > On Fri, Mar 21, 2014 at 08:31:42AM +0100, Per Cederqvist wrote: > >> > > >> >> Signed-off-by: Per Cederqvist > >> >> --- > >> >> guilt-import-commit | 6 +++--- > >> >> 1 file changed, 3 insertions(+), 3 deletions(-) > >> >> > >> >> diff --git a/guilt-import-commit b/guilt-import-commit > >> >> index 20dcee2..9488ded 100755 > >> >> --- a/guilt-import-commit > >> >> +++ b/guilt-import-commit > >> >> @@ -23,7 +23,7 @@ if ! must_commit_first; then > >> >> fi > >> >> > >> >> disp "About to begin conversion..." >&2 > >> >> -disp "Current head: `cat $GIT_DIR/refs/heads/\`git_branch\``" >&2 > >> >> +disp "Current head: `cat \"$GIT_DIR\"/refs/heads/\`git_branch\``" >&2 > >> > > >> > I wonder if it'd be better to use 'git rev-parse' here instead of looking at > >> > the refs directly. > >> > > >> > IOW, > >> > > >> > disp "Current head: `git rev-parse \`git_branch\``" >&2 > >> > >> That is probably a good idea. I only made the minimum change > >> required to get the test suite to pass. > > > > I totally understand. > > > >> > Maybe even $() instead of the inner `` to clean it up some more. > >> > >> Yes, given that that construct is already used in several places > >> it is apparently portable enough for guilt. (I guess nobody uses > >> /bin/sh on Solaris to run guilt. It doesn't support the $(...) > >> construct.) > > > > Hrm? I'm using OpenIndiana (OpenSolaris derivative) and my /bin/sh seems to > > be a symlink to ksh93. What version of Solaris are you seeing this behavior > > on? > > Solaris 10: > > Last login: Sun Mar 23 20:53:28 2014 from c80-217-121-12. > Sun Microsystems Inc. SunOS 5.10 Generic January 2005 > You have mail. > 500 ceder@bacon> uname -a > SunOS bacon 5.10 Generic_147147-26 sun4u sparc SUNW,Sun-Fire-15000 > 501 ceder@bacon> /bin/sh > $ echo `id` > uid=105(ceder) gid=20105(ceder) > $ echo $(id) > syntax error: `(' unexpected > > /bin/sh is a symlink to /sbin/sh. > > On Solaris 10, you are supposed to use /usr/xpg4/bin/sh if you want > a competent standards-compliant shell. /bin/sh is provided as a very > backward-compatible shell. Ok, I finally got back to this series... I'd say let's use the nested ``. Jeff. -- Hegh QaQ law' quvHa'ghach QaQ puS