From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753882AbaETNRD (ORCPT ); Tue, 20 May 2014 09:17:03 -0400 Received: from casper.infradead.org ([85.118.1.10]:33899 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753742AbaETNRA (ORCPT ); Tue, 20 May 2014 09:17:00 -0400 Date: Tue, 20 May 2014 15:16:48 +0200 From: Peter Zijlstra To: David Howells Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, mingo@kernel.org, will.deacon@arm.com, paulmck@linux.vnet.ibm.com, Koichi Yasutake Subject: Re: [PATCH 14/20] arch,mn10300: Fold atomic_ops Message-ID: <20140520131648.GF11096@twins.programming.kicks-ass.net> References: <20140508135852.605324173@infradead.org> <20140508135840.956784204@infradead.org> <26031.1400591132@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dRZtNaFcRiL7vj6v" Content-Disposition: inline In-Reply-To: <26031.1400591132@warthog.procyon.org.uk> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dRZtNaFcRiL7vj6v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 20, 2014 at 02:05:32PM +0100, David Howells wrote: > Peter Zijlstra wrote: >=20 > > +#define ATOMIC_OPS(op) ATOMIC_OP(op) ATOMIC_OP_RETURN(op) >=20 > Can ATOMIC_OP() just be an alias for ATOMIC_OP_RETURN() where that is > appropriate? I suspect several arches (MN10300 included) are going to re= turn > the value *anyway*. I was going to introduce a few new atomic ops that will not have _return() equivalents. So relying on whatever code is generated by ATOMIC_OP_RETURN() is going to be painful. --dRZtNaFcRiL7vj6v Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJTe1XAAAoJEHZH4aRLwOS6R+4P/iFmLo46aXg3Jh3S1BjrTs0u Cq6HQZ1yia8RIDeTIllQsbh8iy6XdFSdbUfx2MT58kPCo4IBpuZYsPoezyHpvmPY sR8z/VqHRv0zvqc1iQkjIY5YFwlo5PF3cYl/X4DtgQPcc11FFC2Kbs5lUeerHOgh JLjgi9zJuhnintknUlvkT4Fdl435gutARVfNwVLRD5/9m5X4tu26DU/LH7Z/PLLw oZwVnhmZO9xqmUPyqSXJjr8v78n3+AIocnfyM2WsSgSYmDNRa8kivWzDEVKsigUa nlr48vCFd85ammQldnJkhac2e48gQGQQx8heS0t6nagtrKDphHpTp34BwRT8zdzX btmqoclgNSOnSS1dyFo3Ufd1qKKn+bXLaIZBGVsEYwB0WEhf1ydm16K1P/kTgy/b aYN2TVdvPQ0/weP0QPPRoMQKm3jmVDYgZtpTKzaUaj+36djtt0wN/9TGTFu564Ew Sr5fuU4bvY/QjVH1d9jBk4/NVFL3/2XoO3lBPg5t08AjVvxRGbgpKAGW5IPF8/LI qet1s0Z45X4ZgdfCMIffr8aCj1JHB78rk8wG+tljb0iKATivb47J/PetvWQYXM9E 6CE118N59IwY6Hukj/X7WtWMQ4c4Dc9VKxQ0nyTMc70OoYE1n2kMdvBCMRN6jxTD WMuQdedASfNJI4TnObSu =j187 -----END PGP SIGNATURE----- --dRZtNaFcRiL7vj6v--