From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luis R. Rodriguez" Subject: Re: [PATCH v5 13/14] xencommons: move module list into a generic place Date: Tue, 20 May 2014 20:03:58 +0200 Message-ID: <20140520180358.GS13289@wotan.suse.de> References: <1400589095-3872-1-git-send-email-mcgrof@do-not-panic.com> <1400589095-3872-14-git-send-email-mcgrof@do-not-panic.com> <537B776D020000780001425E@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WmoOO-0005dQ-Rs for xen-devel@lists.xenproject.org; Tue, 20 May 2014 18:04:01 +0000 Content-Disposition: inline In-Reply-To: <537B776D020000780001425E@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel@lists.xenproject.org, "Luis R. Rodriguez" List-Id: xen-devel@lists.xenproject.org On Tue, May 20, 2014 at 07:40:29AM -0600, Jan Beulich wrote: > >>> On 20.05.14 at 14:31, wrote: > > From: "Luis R. Rodriguez" > > > > This will allows us to share the same module list with > > sysemd, and lets us upkeep it in one place. > > Hmm - do we really want to further play with this module loading, That seems to be orthogonal as I'm not adding or removing extensions to it but simply preserving the existing behavior for both old init and systemd, if anything just documenting the existing behavior. In the last series the modules stuff was discussed and it was pointed out a desire to share and retain only one source for the list of modules, this is why I addressed this in this series. A few regressions were mentioned that seemed to still exist with auto module loading on Linux, this is why this is preserved. > which for at least two releases was scheduled to be removed in > favor of having the tool stack load modules on demand? If this support gets added to the tool stack then both systemd and old init can just remove this part, however the modules xen.conf service unit file might to then be replaced by an ExecStartPre. The *right* solution at least for Linux, as documented in the README is to really fix auto module loading. For Linux at least it would help have documented on the wiki the exact bug numbers for those issues that exist where auto module loading does not work. Luis