From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 1/3] dt: Add DT bindings documentation for SUNXI Security System Date: Sun, 25 May 2014 15:09:31 +0200 Message-ID: <20140525130931.GI10768@lukather> References: <1400771396-9686-1-git-send-email-clabbe.montjoie@gmail.com> <201405242143.42693.marex@denx.de> <5380F85F.7020601@gmail.com> <201405242159.30505.marex@denx.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xQR6quUbZ63TTuTU" Cc: Tomasz Figa , linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux@arm.linux.org.uk, herbert@gondor.apana.org.au, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, rdunlap@infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, LABBE Corentin , linux-crypto@vger.kernel.org, galak@codeaurora.org, grant.likely@linaro.org, davem@davemloft.net To: Marek Vasut Return-path: Content-Disposition: inline In-Reply-To: <201405242159.30505.marex@denx.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org --xQR6quUbZ63TTuTU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 24, 2014 at 09:59:30PM +0200, Marek Vasut wrote: > On Saturday, May 24, 2014 at 09:51:59 PM, Tomasz Figa wrote: > [...] > > >>> Why sun7i-a20 ? Is the crypto unit different in other sunxi chips ?= Can > > >>> that not be described by DT props ? > > >>=20 > > >> A widely used convention is to define compatible strings after first > > >> SoCs on which particular IP blocks appear. It is quite common among = IP > > >> blocks for which there is no well defined versioning scheme. > > >=20 > > > Well yeah, that's fine. But in this case, "sun7i" is the entire group= of > > > CPUs manufactured by AW. I find that information redundant, the > > > "allwinner,a20- crypto" would suffice. But I wonder if that IP block > > > might have appeared even earlier ? Or if it is CPU family specific, t= hus > > > "allwinner,sun7i-crypto" would be a better string ? > >=20 > > I'm not aware of Allwinner naming schemes too much, so please correct me > > if I'm wrong, but if A20 implies sun7i, then "allwinner,a20-crypto" > > would be better indeed. >=20 > True. >=20 > > Whether it was really the first SoC is another thing. Obviously this > > needs to be checked, although it isn't really that important. For this > > particular naming scheme you need to specify all the SoCs for which > > given compatible string can be used for this IP anyway, because there is > > usually no other source of information about this available (except > > directly comparing two datasheets...). >=20 > Better get the DT stuff correctly right from the start. That's why I'm as= king=20 > what chips contains the IP block, so we can guess the right name. The name is fine, please stop this bikeshedding. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --xQR6quUbZ63TTuTU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJTgeuLAAoJEBx+YmzsjxAgAsgP/jOt5x1dVFqyNp8JHXhwwCM/ +498kRuqZX2bYt5j0+c3kH2FzIA6AeEP9gFGry60I3gbdH1M/Tv3UxE9JLieMhid 73UVhciaHwndN+i7J7GKGXNlpJa+7tEjAZvMMsgUWvDNUdLaotes/ogihA9s0TqG 8QcKWVwG7ZeFNtvKOpdiTBncrH4AWmt7/6mD1A1ktk5S3RxbRlDh9VapmlQTVZ6O bSC08udgoUGjtD+aJd+Y9CGS7vfw8wpNLhFX4+14L/ciwTFtyAL9CadFzS1VF84Z AAjBgcIS0CjbULGC5xLzGXRgmh24dtO1bUhSh2tADG04LwurEf8d7qstPic/7qE6 hbRK6b96vpAw+L6uvIrUIH/9DCpdlrIeLNoB89AODRGPFX4dSYowhKlQ+SF866CS wby1jyLTUepQ87NxSoTgzJEww49gtwKCZw5lEHi/jGo/Tzq01bZG/RpUPQyt+3WR fYE81HubHzi6NBtinJfiwNbCBDsq8Ha+GruDnONNaJ5N2jHh1jdn89wKH5//4pnn 2L7wGz4a5gLEhL9QbZL/Ufyei58Kgkav04U0y6wRMGg3hMs3WopHHvN15gTBGlh6 WIuuDz1d6cy3IDnqHcsRa+gahFZxwr3J2uNLjlGPYNTYIzVrLyJwWpH0yJUTK23F U6CiRpCzMCPq2gVFrVjk =oTL/ -----END PGP SIGNATURE----- --xQR6quUbZ63TTuTU-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Sun, 25 May 2014 15:09:31 +0200 Subject: [PATCH 1/3] dt: Add DT bindings documentation for SUNXI Security System In-Reply-To: <201405242159.30505.marex@denx.de> References: <1400771396-9686-1-git-send-email-clabbe.montjoie@gmail.com> <201405242143.42693.marex@denx.de> <5380F85F.7020601@gmail.com> <201405242159.30505.marex@denx.de> Message-ID: <20140525130931.GI10768@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, May 24, 2014 at 09:59:30PM +0200, Marek Vasut wrote: > On Saturday, May 24, 2014 at 09:51:59 PM, Tomasz Figa wrote: > [...] > > >>> Why sun7i-a20 ? Is the crypto unit different in other sunxi chips ? Can > > >>> that not be described by DT props ? > > >> > > >> A widely used convention is to define compatible strings after first > > >> SoCs on which particular IP blocks appear. It is quite common among IP > > >> blocks for which there is no well defined versioning scheme. > > > > > > Well yeah, that's fine. But in this case, "sun7i" is the entire group of > > > CPUs manufactured by AW. I find that information redundant, the > > > "allwinner,a20- crypto" would suffice. But I wonder if that IP block > > > might have appeared even earlier ? Or if it is CPU family specific, thus > > > "allwinner,sun7i-crypto" would be a better string ? > > > > I'm not aware of Allwinner naming schemes too much, so please correct me > > if I'm wrong, but if A20 implies sun7i, then "allwinner,a20-crypto" > > would be better indeed. > > True. > > > Whether it was really the first SoC is another thing. Obviously this > > needs to be checked, although it isn't really that important. For this > > particular naming scheme you need to specify all the SoCs for which > > given compatible string can be used for this IP anyway, because there is > > usually no other source of information about this available (except > > directly comparing two datasheets...). > > Better get the DT stuff correctly right from the start. That's why I'm asking > what chips contains the IP block, so we can guess the right name. The name is fine, please stop this bikeshedding. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: