From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 2/4] drm/i915: leave rc6 enabled at suspend time Date: Fri, 30 May 2014 11:20:12 -0700 Message-ID: <20140530112012.005ecede@jbarnes-desktop> References: <1401397897-4655-1-git-send-email-jbarnes@virtuousgeek.org> <1401397897-4655-2-git-send-email-jbarnes@virtuousgeek.org> <1401454477.24060.32.camel@intelbox> <20140530083220.08b9b541@jbarnes-desktop> <20140530154027.GA10916@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pd0-f175.google.com (mail-pd0-f175.google.com [209.85.192.175]) by gabe.freedesktop.org (Postfix) with ESMTP id 02F2E6E39D for ; Fri, 30 May 2014 11:19:54 -0700 (PDT) Received: by mail-pd0-f175.google.com with SMTP id z10so1211539pdj.20 for ; Fri, 30 May 2014 11:19:54 -0700 (PDT) In-Reply-To: <20140530154027.GA10916@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, kristen@linux.intel.com List-Id: intel-gfx@lists.freedesktop.org On Fri, 30 May 2014 16:40:27 +0100 Chris Wilson wrote: > On Fri, May 30, 2014 at 08:32:20AM -0700, Jesse Barnes wrote: > > But I can split that out if there's a reason to. Seems like we do a > > bit too much teardown at suspend these days (like tearing down opregion > > state), I'd like to trim it back if possible and share between runtime > > and system suspend/freeze. > > I guess the answer is to move all the paranoid bits from suspend into > hibernate-resume. Well and probably move a bunch of stuff out of _freeze and into a shared _suspend function for use at runtime suspend, suspend, and hibernate. Separate patches for all of that though so all the breakage is easily bisected. :) -- Jesse Barnes, Intel Open Source Technology Center