From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle Date: Fri, 30 May 2014 15:48:59 +0000 Subject: Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void Message-Id: <20140530154859.GK17197@linux-mips.org> List-Id: References: <20140530094025.3b78301e@canb.auug.org.au> <1401449454-30895-1-git-send-email-berthe.ab@gmail.com> <1401449454-30895-2-git-send-email-berthe.ab@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Fri, May 30, 2014 at 01:39:15PM +0200, Geert Uytterhoeven wrote: > > + if (test_bit(FLAG_REQUESTED, &chip->desc[id].flags)) > > + panic("gpio: removing gpiochip with gpios still requested\n"); > > panic? > > Is this likely to happen? And while we're at it - panic() is going to add a \n itself so don't pass a string ending in \n to panic(). Ralf From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from eddie.linux-mips.org ([78.24.191.182]:42858 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932189AbaE3Pt2 (ORCPT ); Fri, 30 May 2014 11:49:28 -0400 Date: Fri, 30 May 2014 17:48:59 +0200 From: Ralf Baechle To: Geert Uytterhoeven Cc: abdoulaye berthe , Linus Walleij , Alexandre Courbot , m@bues.ch, "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux MIPS Mailing List , "linuxppc-dev@lists.ozlabs.org" , Linux-sh list , linux-wireless , patches@opensource.wolfsonmicro.com, "linux-input@vger.kernel.org" , "linux-leds@vger.kernel.org" , Linux Media Mailing List , linux-samsungsoc@vger.kernel.org, spear-devel@list.st.com, platform-driver-x86@vger.kernel.org, "netdev@vger.kernel.org" , driverdevel Subject: Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void Message-ID: <20140530154859.GK17197@linux-mips.org> (sfid-20140530_174946_179538_F8D2B24F) References: <20140530094025.3b78301e@canb.auug.org.au> <1401449454-30895-1-git-send-email-berthe.ab@gmail.com> <1401449454-30895-2-git-send-email-berthe.ab@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, May 30, 2014 at 01:39:15PM +0200, Geert Uytterhoeven wrote: > > + if (test_bit(FLAG_REQUESTED, &chip->desc[id].flags)) > > + panic("gpio: removing gpiochip with gpios still requested\n"); > > panic? > > Is this likely to happen? And while we're at it - panic() is going to add a \n itself so don't pass a string ending in \n to panic(). Ralf From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle Subject: Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void Date: Fri, 30 May 2014 17:48:59 +0200 Message-ID: <20140530154859.GK17197@linux-mips.org> References: <20140530094025.3b78301e@canb.auug.org.au> <1401449454-30895-1-git-send-email-berthe.ab@gmail.com> <1401449454-30895-2-git-send-email-berthe.ab@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: platform-driver-x86-owner@vger.kernel.org To: Geert Uytterhoeven Cc: abdoulaye berthe , Linus Walleij , Alexandre Courbot , m@bues.ch, "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux MIPS Mailing List , "linuxppc-dev@lists.ozlabs.org" , Linux-sh list , linux-wireless , patches@opensource.wolfsonmicro.com, "linux-input@vger.kernel.org" , "linux-leds@vger.kernel.org" , Linux Media Mailing List , linux-samsungsoc@vger.kernel.org, spear-devel@list.st.com, platform-driver-x86@vger.kernel.org"netdev@vger.kernel.org" List-Id: linux-leds@vger.kernel.org On Fri, May 30, 2014 at 01:39:15PM +0200, Geert Uytterhoeven wrote: > > + if (test_bit(FLAG_REQUESTED, &chip->desc[id].flags)) > > + panic("gpio: removing gpiochip with gpios still requested\n"); > > panic? > > Is this likely to happen? And while we're at it - panic() is going to add a \n itself so don't pass a string ending in \n to panic(). Ralf From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933836AbaE3Ptd (ORCPT ); Fri, 30 May 2014 11:49:33 -0400 Received: from eddie.linux-mips.org ([78.24.191.182]:42858 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932189AbaE3Pt2 (ORCPT ); Fri, 30 May 2014 11:49:28 -0400 Date: Fri, 30 May 2014 17:48:59 +0200 From: Ralf Baechle To: Geert Uytterhoeven Cc: abdoulaye berthe , Linus Walleij , Alexandre Courbot , m@bues.ch, "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux MIPS Mailing List , "linuxppc-dev@lists.ozlabs.org" , Linux-sh list , linux-wireless , patches@opensource.wolfsonmicro.com, "linux-input@vger.kernel.org" , "linux-leds@vger.kernel.org" , Linux Media Mailing List , linux-samsungsoc@vger.kernel.org, spear-devel@list.st.com, platform-driver-x86@vger.kernel.org, "netdev@vger.kernel.org" , driverdevel Subject: Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void Message-ID: <20140530154859.GK17197@linux-mips.org> References: <20140530094025.3b78301e@canb.auug.org.au> <1401449454-30895-1-git-send-email-berthe.ab@gmail.com> <1401449454-30895-2-git-send-email-berthe.ab@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 30, 2014 at 01:39:15PM +0200, Geert Uytterhoeven wrote: > > + if (test_bit(FLAG_REQUESTED, &chip->desc[id].flags)) > > + panic("gpio: removing gpiochip with gpios still requested\n"); > > panic? > > Is this likely to happen? And while we're at it - panic() is going to add a \n itself so don't pass a string ending in \n to panic(). Ralf From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle Subject: Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void Date: Fri, 30 May 2014 17:48:59 +0200 Message-ID: <20140530154859.GK17197@linux-mips.org> References: <20140530094025.3b78301e@canb.auug.org.au> <1401449454-30895-1-git-send-email-berthe.ab@gmail.com> <1401449454-30895-2-git-send-email-berthe.ab@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: abdoulaye berthe , Linus Walleij , Alexandre Courbot , m@bues.ch, "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux MIPS Mailing List , "linuxppc-dev@lists.ozlabs.org" , Linux-sh list , linux-wireless , patches@opensource.wolfsonmicro.com, "linux-input@vger.kernel.org" , "linux-leds@vger.kernel.org" , Linux Media Mailing List , linux-samsungsoc@vger.kernel.org, spear-devel@list.st.com, platform-driver-x86@vger.kernel.org, "netdev@vger.kernel.org" Return-path: Received: from localhost.localdomain ([127.0.0.1]:33467 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S6833152AbaE3PtXl0Gmk (ORCPT + 9 others); Fri, 30 May 2014 17:49:23 +0200 Content-Disposition: inline In-Reply-To: Sender: platform-driver-x86-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, May 30, 2014 at 01:39:15PM +0200, Geert Uytterhoeven wrote: > > + if (test_bit(FLAG_REQUESTED, &chip->desc[id].flags)) > > + panic("gpio: removing gpiochip with gpios still requested\n"); > > panic? > > Is this likely to happen? And while we're at it - panic() is going to add a \n itself so don't pass a string ending in \n to panic(). Ralf From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from git.linux-mips.org (marvin.linux-mips.org [78.24.191.183]) by lists.ozlabs.org (Postfix) with ESMTP id 5E0461A06CD for ; Sat, 31 May 2014 01:49:24 +1000 (EST) Received: from localhost.localdomain ([127.0.0.1]:33465 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S6825887AbaE3PtT13Thq (ORCPT ); Fri, 30 May 2014 17:49:19 +0200 Date: Fri, 30 May 2014 17:48:59 +0200 From: Ralf Baechle To: Geert Uytterhoeven Subject: Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void Message-ID: <20140530154859.GK17197@linux-mips.org> References: <20140530094025.3b78301e@canb.auug.org.au> <1401449454-30895-1-git-send-email-berthe.ab@gmail.com> <1401449454-30895-2-git-send-email-berthe.ab@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Cc: platform-driver-x86@vger.kernel.org, Alexandre Courbot , patches@opensource.wolfsonmicro.com, Linux MIPS Mailing List , "netdev@vger.kernel.org" , Linus Walleij , Linux-sh list , linux-wireless , "linux-kernel@vger.kernel.org" , spear-devel@list.st.com, linux-samsungsoc@vger.kernel.org, "linux-gpio@vger.kernel.org" , "linux-leds@vger.kernel.org" , m@bues.ch, "linux-input@vger.kernel.org" , driverdevel , Linux Media Mailing List , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , abdoulaye berthe List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, May 30, 2014 at 01:39:15PM +0200, Geert Uytterhoeven wrote: > > + if (test_bit(FLAG_REQUESTED, &chip->desc[id].flags)) > > + panic("gpio: removing gpiochip with gpios still requested\n"); > > panic? > > Is this likely to happen? And while we're at it - panic() is going to add a \n itself so don't pass a string ending in \n to panic(). Ralf From mboxrd@z Thu Jan 1 00:00:00 1970 From: ralf@linux-mips.org (Ralf Baechle) Date: Fri, 30 May 2014 17:48:59 +0200 Subject: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void In-Reply-To: References: <20140530094025.3b78301e@canb.auug.org.au> <1401449454-30895-1-git-send-email-berthe.ab@gmail.com> <1401449454-30895-2-git-send-email-berthe.ab@gmail.com> Message-ID: <20140530154859.GK17197@linux-mips.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, May 30, 2014 at 01:39:15PM +0200, Geert Uytterhoeven wrote: > > + if (test_bit(FLAG_REQUESTED, &chip->desc[id].flags)) > > + panic("gpio: removing gpiochip with gpios still requested\n"); > > panic? > > Is this likely to happen? And while we're at it - panic() is going to add a \n itself so don't pass a string ending in \n to panic(). Ralf