From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH 5/7 v6] trace, RAS: Add eMCA trace event interface Date: Fri, 30 May 2014 23:26:53 +0200 Message-ID: <20140530212653.GK28131@pd.tnic> References: <1400142646-10127-1-git-send-email-gong.chen@linux.intel.com> <1401247938-22125-1-git-send-email-gong.chen@linux.intel.com> <1401247938-22125-2-git-send-email-gong.chen@linux.intel.com> <20140528112832.5f83c66b@gandalf.local.home> <20140528163452.GF17196@pd.tnic> <20140528125625.6f6dcf7f@gandalf.local.home> <20140530092232.GA13495@gchen.bj.intel.com> <20140530100716.GE28131@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mail.skyhub.de ([78.46.96.112]:35633 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754611AbaE3V1D (ORCPT ); Fri, 30 May 2014 17:27:03 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Tony Luck Cc: "Chen, Gong" , Steven Rostedt , "m.chehab@samsung.com" , linux-acpi , LKML On Fri, May 30, 2014 at 02:16:06PM -0700, Tony Luck wrote: > On Fri, May 30, 2014 at 3:07 AM, Borislav Petkov wrote: > > Please elaborate, what conditions? DIMM silk screen labels or so? Maybe > > we can generate a mapping between text labels and indices and we can > > dump the indices in the tracepoint and do the mapping back to strings in > > userspace...? > > The UEFI error record gives us the SMBIOS "handle" (2-byte index). We > use that to look up the bank and device locator strings ... which should be > the silk-screen labels (in a correctly written BIOS). Ok, sounds straightforward. > So we could just have the tracepoint save the "handle" and do the > decode later. If we want to keep doing mappings in the kernel (so > console logs can say "DIMM location: CPU 0 DIMM_C1" rather than > "SMBIOS handle 0x0015") - and would like to make things easier for > ourselves - we could have dmi_memdev_walk() do a bit more work > so we can just index an allocated array of strings that are the > concatenation of the bank/device locators. Right, we probably would need both: if a userspace agent is active, it'd need to resolve the handle and otherwise we'll be doing it in the kernel with dmi. But it all sounds very doable and nice to me. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --