From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932972AbaFCQBw (ORCPT ); Tue, 3 Jun 2014 12:01:52 -0400 Received: from mail.skyhub.de ([78.46.96.112]:47454 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932308AbaFCQBu (ORCPT ); Tue, 3 Jun 2014 12:01:50 -0400 Date: Tue, 3 Jun 2014 18:01:26 +0200 From: Borislav Petkov To: Vivek Goyal Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, hpa@zytor.com, mjg59@srcf.ucam.org, greg@kroah.com, jkosina@suse.cz, dyoung@redhat.com, chaowang@redhat.com, bhe@redhat.com, akpm@linux-foundation.org Subject: Re: [PATCH 01/13] bin2c: Move bin2c in scripts/basic Message-ID: <20140603160126.GB18806@pd.tnic> References: <1401800822-27425-1-git-send-email-vgoyal@redhat.com> <1401800822-27425-2-git-send-email-vgoyal@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1401800822-27425-2-git-send-email-vgoyal@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 03, 2014 at 09:06:50AM -0400, Vivek Goyal wrote: > Kexec wants to use bin2c and it wants to use it really early in the build > process. See arch/x86/purgatory/ code in later patches. > > So move bin2c in scripts/basic so that it can be built very early and > be usable by arch/x86/purgatory/ > > Signed-off-by: Vivek Goyal > --- > kernel/Makefile | 2 +- > scripts/Makefile | 1 - > scripts/basic/Makefile | 1 + > scripts/basic/bin2c.c | 35 +++++++++++++++++++++++++++++++++++ > scripts/bin2c.c | 36 ------------------------------------ > 5 files changed, 37 insertions(+), 38 deletions(-) > create mode 100644 scripts/basic/bin2c.c > delete mode 100644 scripts/bin2c.c > > diff --git a/kernel/Makefile b/kernel/Makefile > index f2a8b62..9b07bb7 100644 > --- a/kernel/Makefile > +++ b/kernel/Makefile > @@ -105,7 +105,7 @@ targets += config_data.gz > $(obj)/config_data.gz: $(KCONFIG_CONFIG) FORCE > $(call if_changed,gzip) > > - filechk_ikconfiggz = (echo "static const char kernel_config_data[] __used = MAGIC_START"; cat $< | scripts/bin2c; echo "MAGIC_END;") > + filechk_ikconfiggz = (echo "static const char kernel_config_data[] __used = MAGIC_START"; cat $< | scripts/basic/bin2c; echo "MAGIC_END;") > targets += config_data.h > $(obj)/config_data.h: $(obj)/config_data.gz FORCE > $(call filechk,ikconfiggz) > diff --git a/scripts/Makefile b/scripts/Makefile > index 1d07860..e9d56fb 100644 > --- a/scripts/Makefile > +++ b/scripts/Makefile > @@ -13,7 +13,6 @@ HOST_EXTRACFLAGS += -I$(srctree)/tools/include > hostprogs-$(CONFIG_KALLSYMS) += kallsyms > hostprogs-$(CONFIG_LOGO) += pnmtologo > hostprogs-$(CONFIG_VT) += conmakehash > -hostprogs-$(CONFIG_IKCONFIG) += bin2c You also'd need to move the "bin2c" entry from scripts/.gitignore to scripts/basic/.gitignore. I just noticed this by grepping around the sources. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.skyhub.de ([2a01:4f8:120:8448::d00d]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WrrAG-0001fP-Qe for kexec@lists.infradead.org; Tue, 03 Jun 2014 16:02:19 +0000 Date: Tue, 3 Jun 2014 18:01:26 +0200 From: Borislav Petkov Subject: Re: [PATCH 01/13] bin2c: Move bin2c in scripts/basic Message-ID: <20140603160126.GB18806@pd.tnic> References: <1401800822-27425-1-git-send-email-vgoyal@redhat.com> <1401800822-27425-2-git-send-email-vgoyal@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1401800822-27425-2-git-send-email-vgoyal@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Vivek Goyal Cc: mjg59@srcf.ucam.org, bhe@redhat.com, jkosina@suse.cz, greg@kroah.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, ebiederm@xmission.com, hpa@zytor.com, akpm@linux-foundation.org, dyoung@redhat.com, chaowang@redhat.com On Tue, Jun 03, 2014 at 09:06:50AM -0400, Vivek Goyal wrote: > Kexec wants to use bin2c and it wants to use it really early in the build > process. See arch/x86/purgatory/ code in later patches. > > So move bin2c in scripts/basic so that it can be built very early and > be usable by arch/x86/purgatory/ > > Signed-off-by: Vivek Goyal > --- > kernel/Makefile | 2 +- > scripts/Makefile | 1 - > scripts/basic/Makefile | 1 + > scripts/basic/bin2c.c | 35 +++++++++++++++++++++++++++++++++++ > scripts/bin2c.c | 36 ------------------------------------ > 5 files changed, 37 insertions(+), 38 deletions(-) > create mode 100644 scripts/basic/bin2c.c > delete mode 100644 scripts/bin2c.c > > diff --git a/kernel/Makefile b/kernel/Makefile > index f2a8b62..9b07bb7 100644 > --- a/kernel/Makefile > +++ b/kernel/Makefile > @@ -105,7 +105,7 @@ targets += config_data.gz > $(obj)/config_data.gz: $(KCONFIG_CONFIG) FORCE > $(call if_changed,gzip) > > - filechk_ikconfiggz = (echo "static const char kernel_config_data[] __used = MAGIC_START"; cat $< | scripts/bin2c; echo "MAGIC_END;") > + filechk_ikconfiggz = (echo "static const char kernel_config_data[] __used = MAGIC_START"; cat $< | scripts/basic/bin2c; echo "MAGIC_END;") > targets += config_data.h > $(obj)/config_data.h: $(obj)/config_data.gz FORCE > $(call filechk,ikconfiggz) > diff --git a/scripts/Makefile b/scripts/Makefile > index 1d07860..e9d56fb 100644 > --- a/scripts/Makefile > +++ b/scripts/Makefile > @@ -13,7 +13,6 @@ HOST_EXTRACFLAGS += -I$(srctree)/tools/include > hostprogs-$(CONFIG_KALLSYMS) += kallsyms > hostprogs-$(CONFIG_LOGO) += pnmtologo > hostprogs-$(CONFIG_VT) += conmakehash > -hostprogs-$(CONFIG_IKCONFIG) += bin2c You also'd need to move the "bin2c" entry from scripts/.gitignore to scripts/basic/.gitignore. I just noticed this by grepping around the sources. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec