All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Davidlohr Bueso <davidlohr@hp.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	"Paul E. McKenney" <paulmck@us.ibm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL] locking tree changes for v3.16
Date: Thu, 5 Jun 2014 13:20:35 +0200	[thread overview]
Message-ID: <20140605112035.GA27384@gmail.com> (raw)
In-Reply-To: <20140605111110.GA26771@gmail.com>


* Ingo Molnar <mingo@kernel.org> wrote:

> Not unexpected the breakage comes from:
> 
>  5627b9d439cc4dfaab738b8c21eef10fb40733f8 is the first bad commit
>  commit 5627b9d439cc4dfaab738b8c21eef10fb40733f8
>  Author: Waiman Long <Waiman.Long@hp.com>
>  Date:   Mon Feb 3 13:18:57 2014 +0100
> 
>     x86, locking: Switch x86 to qrwlock-style rwlocks and optimize it
>     
>     Make x86 use the fair rwlock_t.
> 
> Please also split the feature-enabling and the optimization into two 
> separate patches.

So a bit of an update: I've done the first part of the splitup: the 
simple enablement of qrwlock-style rwlocks on x86.

But even that leaves build errors:

  include/asm-generic/qrwlock_types.h:14:3: error: conflicting types for ‘arch_rwlock_t’

Which means the base patch is broken:

  78e077b0c5ec locking/qrwlock: Introduce qrwlock

I've picked up the other patches (rwsem optimistic spinning and 
fallout), and can apply the qwrlock patches once they are fixed and 
properly split up.

Thanks,

	Ingo

  reply	other threads:[~2014-06-05 11:20 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-03 11:48 [GIT PULL] locking tree changes for v3.16 Ingo Molnar
2014-06-03 21:50 ` Davidlohr Bueso
2014-06-03 21:55   ` Andrew Morton
2014-06-03 22:02     ` Davidlohr Bueso
2014-06-03 22:53       ` Andrew Morton
2014-06-04 10:30   ` Peter Zijlstra
2014-06-04 16:17     ` Linus Torvalds
2014-06-04 17:22       ` Peter Zijlstra
2014-06-04 21:22         ` Linus Torvalds
2014-06-04 21:35           ` Thomas Gleixner
2014-06-05  1:22           ` Davidlohr Bueso
2014-06-05  8:19           ` Ingo Molnar
2014-06-05  8:22             ` Thomas Gleixner
2014-06-05  8:29               ` Ingo Molnar
2014-06-05  8:17     ` Ingo Molnar
2014-06-05  9:21       ` Peter Zijlstra
2014-06-05  9:24         ` Ingo Molnar
2014-06-05 11:11       ` Ingo Molnar
2014-06-05 11:20         ` Ingo Molnar [this message]
2014-06-05 12:27         ` Peter Zijlstra
2014-06-05 12:35           ` Ingo Molnar
2014-06-05 12:41             ` Peter Zijlstra
2014-06-05 12:47               ` Ingo Molnar
2014-06-05 12:53         ` Peter Zijlstra
2014-06-05 13:13           ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140605112035.GA27384@gmail.com \
    --to=mingo@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=davidlohr@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@us.ibm.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.