From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 04/15] drm/i915: ns2501 is on DVOB
Date: Fri, 6 Jun 2014 18:57:43 +0200
Message-ID: <20140606165743.GK7416@phenom.ffwll.local>
References: <1401984964-25441-1-git-send-email-ville.syrjala@linux.intel.com>
 <1401984964-25441-5-git-send-email-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42])
 by gabe.freedesktop.org (Postfix) with ESMTP id 4CCCB6E3C1
 for <intel-gfx@lists.freedesktop.org>; Fri,  6 Jun 2014 09:57:48 -0700 (PDT)
Received: by mail-wg0-f42.google.com with SMTP id y10so3058928wgg.13
 for <intel-gfx@lists.freedesktop.org>; Fri, 06 Jun 2014 09:57:47 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1401984964-25441-5-git-send-email-ville.syrjala@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: ville.syrjala@linux.intel.com
Cc: Thomas Richter <richter@rus.uni-stuttgart.de>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Jun 05, 2014 at 07:15:53PM +0300, ville.syrjala@linux.intel.com wro=
te:
> From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> =

> On Fujitsu-Siememens S6010 the ns2501 chip is hooked up to DVOB instead
> of DVOC.
> =

> FIXME: Maybe need to dig out the correct DVO port from VBT

Well we could have 2 match structs for dvoc and dvob. I guess on Thomas'
X30 it is actually on dvob, otherwise he wouldn't have picked that one ...
-Daniel

> =

> Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dvo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> =

> diff --git a/drivers/gpu/drm/i915/intel_dvo.c b/drivers/gpu/drm/i915/inte=
l_dvo.c
> index 5d7d975..be560bb 100644
> --- a/drivers/gpu/drm/i915/intel_dvo.c
> +++ b/drivers/gpu/drm/i915/intel_dvo.c
> @@ -85,7 +85,7 @@ static const struct intel_dvo_device intel_dvo_devices[=
] =3D {
>  	{
>  	        .type =3D INTEL_DVO_CHIP_TMDS,
>  		.name =3D "ns2501",
> -		.dvo_reg =3D DVOC,
> +		.dvo_reg =3D DVOB,
>  		.slave_addr =3D NS2501_ADDR,
>  		.dev_ops =3D &ns2501_ops,
>         }
> -- =

> 1.8.5.5
> =

> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch