All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: Christoffer Dall <christoffer.dall@linaro.org>
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Subject: Re: [PATCH v4 00/19] kvm-unit-tests/arm: initial drop
Date: Mon, 9 Jun 2014 11:51:40 +0200	[thread overview]
Message-ID: <20140609095139.GE3024@dhcp-27-201.brq.redhat.com> (raw)
In-Reply-To: <20140606184144.GV3994@lvm>

On Fri, Jun 06, 2014 at 08:41:44PM +0200, Christoffer Dall wrote:
> On Thu, Apr 10, 2014 at 06:56:41PM +0200, Andrew Jones wrote:
> > This is a v4 of a series that introduces arm to kvm-unit-tests. First,
> > it does some tidying up of the repo. Then, it adds support for device
> > trees (libfdt), and for virtio-testdev[1]. Next, it adds the basic
> > infrastructure for booting a test case (guest), and adds a first
> > test case, a self-test to confirm setup was completed successfully.
> > Finally, it further prepares the framework for more complicated tests
> > by adding vector support, and extends the self-test to test that too.
> > 
> > This initial drop doesn't require kvmarm. qemu-system-arm is enough,
> > but it must have mach-virt, and the virtio-testdev patch[1].
> > 
> 
> This is overall looking really good!
> 
> I only had a few comments and questions, but you should be able to sort
> that out quickly.
> 
> It's a lot of code and growing for every iteration, and this time it was
> a long gap since the last review, so it took me a while.
> 
> I think it would be great if you can address my comments quickly and we
> can this merged without futher churn and let new functionality come as
> separate extra patches afterwards.

Thanks a million for the reviewing! I'll get v5 with your acked-by's and
reviewed-by's and comments addressed sent out today or tomorrow.

drew

  reply	other threads:[~2014-06-09  9:51 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10 16:56 [PATCH v4 00/19] kvm-unit-tests/arm: initial drop Andrew Jones
2014-04-10 16:56 ` [PATCH v4 01/19] remove unused files Andrew Jones
2014-06-06 18:37   ` Christoffer Dall
2014-06-09  8:11     ` Andrew Jones
2014-06-25 12:14       ` Alexander Graf
2014-04-10 16:56 ` [PATCH v4 02/19] makefile and run_tests tweaks Andrew Jones
2014-06-06 18:37   ` Christoffer Dall
2014-04-10 16:56 ` [PATCH v4 03/19] clean root dir of all x86-ness Andrew Jones
2014-06-06 18:37   ` Christoffer Dall
2014-04-10 16:56 ` [PATCH v4 04/19] add distclean target and gitignore more Andrew Jones
2014-06-06 18:37   ` Christoffer Dall
2014-04-10 16:56 ` [PATCH v4 05/19] add 'make cscope' support Andrew Jones
2014-06-06 18:38   ` Christoffer Dall
2014-04-10 16:56 ` [PATCH v4 07/19] libfdt: get libfdt to build Andrew Jones
2014-06-06 18:38   ` Christoffer Dall
2014-04-10 16:56 ` [PATCH v4 08/19] add support for Linux device trees Andrew Jones
2014-06-06 18:38   ` Christoffer Dall
2014-06-09 10:18     ` Andrew Jones
2014-06-09 10:45       ` Christoffer Dall
2014-04-10 16:56 ` [PATCH v4 09/19] libcflat: add abort() and assert() Andrew Jones
2014-06-06 18:38   ` Christoffer Dall
2014-04-10 16:56 ` [PATCH v4 10/19] Introduce asm-generic/*.h files Andrew Jones
2014-06-06 18:39   ` Christoffer Dall
2014-06-09  8:23     ` Andrew Jones
2014-06-09  9:08       ` Christoffer Dall
2014-06-09  9:54         ` Andrew Jones
2014-06-09 11:39           ` Andrew Jones
2014-06-09 12:34             ` Christoffer Dall
2014-06-09 13:52               ` Andrew Jones
2014-06-09 15:34                 ` Christoffer Dall
2014-04-10 16:56 ` [PATCH v4 11/19] add minimal virtio support for devtree virtio-mmio Andrew Jones
2014-06-06 18:39   ` Christoffer Dall
2014-06-09  9:02     ` Andrew Jones
2014-06-09  9:14       ` Christoffer Dall
2014-06-09 10:21         ` Andrew Jones
2014-04-10 16:56 ` [PATCH v4 12/19] Introduce virtio-testdev Andrew Jones
2014-06-06 18:39   ` Christoffer Dall
2014-04-10 16:56 ` [PATCH v4 13/19] libcflat: clean up libcflat.h and add string.h Andrew Jones
2014-06-06 18:39   ` Christoffer Dall
2014-04-10 16:56 ` [PATCH v4 14/19] printf: support field padding Andrew Jones
2014-06-06 18:39   ` Christoffer Dall
2014-04-10 16:56 ` [PATCH v4 15/19] arm: initial drop Andrew Jones
2014-06-06 18:39   ` Christoffer Dall
2014-06-09  9:44     ` Andrew Jones
2014-04-10 16:56 ` [PATCH v4 16/19] arm: Add spinlock implementation Andrew Jones
2014-04-10 16:56 ` [PATCH v4 17/19] arm: Add IO accessors to avoid register-writeback Andrew Jones
2014-04-10 16:56 ` [PATCH v4 18/19] arm: add useful headers from the Linux kernel Andrew Jones
2014-06-06 18:40   ` Christoffer Dall
2014-04-10 16:57 ` [PATCH v4 19/19] arm: vectors support Andrew Jones
2014-06-06 18:40   ` Christoffer Dall
     [not found] ` <1397149020-3501-7-git-send-email-drjones@redhat.com>
2014-06-06 18:38   ` [PATCH v4 06/19] libfdt: Import libfdt source Christoffer Dall
2014-06-06 18:41 ` [PATCH v4 00/19] kvm-unit-tests/arm: initial drop Christoffer Dall
2014-06-09  9:51   ` Andrew Jones [this message]
2014-06-09  9:57     ` Christoffer Dall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140609095139.GE3024@dhcp-27-201.brq.redhat.com \
    --to=drjones@redhat.com \
    --cc=christoffer.dall@linaro.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.