All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: pshelar@nicira.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] ip_tunnel: GSO: Add check for nested encap.
Date: Tue, 10 Jun 2014 22:21:20 -0700 (PDT)	[thread overview]
Message-ID: <20140610.222120.1648194413371340927.davem@davemloft.net> (raw)
In-Reply-To: <1401017972-1544-1-git-send-email-pshelar@nicira.com>

From: Pravin B Shelar <pshelar@nicira.com>
Date: Sun, 25 May 2014 04:39:32 -0700

> +	if (skb_is_gso(skb)) {
> +		if (unlikely(skb->encapsulation)) {
> +			/* Current networking GSO stack can handle
> +			 * only one level of encapsulation. */
> +			err = -ENOSYS;
> +			goto error;
> +		}

This is not the correct way to format a comment in the kernel networking
code, the proper way is:

	/* Like
	 * this.
	 */

Also, you need to provide a cover posting for a patch series explaining
at a high level what this patch series is accomplishing.  Also you need
to explicitly indicate what tree this set of changes is targetting.

Given the amount of changes you've contributed in the past, I am at a
loss as to why I have to explain all of this to someone with your level
of experience.

  parent reply	other threads:[~2014-06-11  5:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-25 11:39 [PATCH 1/2] ip_tunnel: GSO: Add check for nested encap Pravin B Shelar
2014-06-10 15:34 ` Tom Herbert
2014-06-12 15:32   ` Pravin Shelar
2014-06-12 17:48     ` Tom Herbert
2014-06-12 20:56       ` Pravin Shelar
2014-06-11  5:21 ` David Miller [this message]
2014-06-12 15:35   ` Pravin Shelar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140610.222120.1648194413371340927.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@nicira.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.