From: Wei Liu <wei.liu2@citrix.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Josh Boyer <jwboyer@fedoraproject.org>,
Wei Liu <wei.liu2@citrix.com>,
netdev@vger.kernel.org, xen-devel@lists.xenproject.org,
"Andrew J. Bennieston" <andrew.bennieston@citrix.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH] net: xen-netback: include linux/vmalloc.h again
Date: Tue, 10 Jun 2014 09:44:54 +0100 [thread overview]
Message-ID: <20140610084454.GB28084__22628.4751938239$1402389997$gmane$org@zion.uk.xensource.com> (raw)
In-Reply-To: <5508988.K5Wec8A6hA@wuerfel>
On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:
> commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
> queue struct") added a use of vzalloc/vfree to interface.c, but
> removed the #include <linux/vmalloc.h> statement at the same time,
> which causes this build error:
>
> drivers/net/xen-netback/interface.c: In function 'xenvif_free':
> drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> vfree(vif->queues);
> ^
> cc1: some warnings being treated as errors
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
This didn't happen to me when I built it on x86 though. Just curious,
did you build it on othet platform, say, ARM?
Wei.
next prev parent reply other threads:[~2014-06-10 8:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 8:34 [PATCH] net: xen-netback: include linux/vmalloc.h again Arnd Bergmann
2014-06-10 8:44 ` Wei Liu
2014-06-10 8:52 ` [Xen-devel] " Ian Campbell
2014-06-10 8:52 ` Ian Campbell
2014-06-11 22:19 ` David Miller
2014-06-12 9:07 ` Wei Liu
2014-06-12 9:07 ` Wei Liu
2014-06-11 22:19 ` David Miller
2014-06-10 8:44 ` Wei Liu [this message]
2014-06-11 22:19 ` David Miller
2014-06-11 22:19 ` David Miller
2014-06-10 8:34 Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20140610084454.GB28084__22628.4751938239$1402389997$gmane$org@zion.uk.xensource.com' \
--to=wei.liu2@citrix.com \
--cc=andrew.bennieston@citrix.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=jwboyer@fedoraproject.org \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.