Re: [PATCH 2/5] implement submodule config cache for lookup of submodule names

From: Heiko Voigt <hvoigt@hvoigt.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Git List <git@vger.kernel.org>,
	Jens Lehmann <jens.lehmann@web.de>,
	Jonathan Nieder <jrnieder@gmail.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH 2/5] implement submodule config cache for lookup of submodule names
Date: Tue, 10 Jun 2014 12:19:27 +0200	[thread overview]
Message-ID: <20140610101927.GA23384@t2784.greatnet.de> (raw)
In-Reply-To: <CAPig+cTmXu09QLca4W=VpUS82m0uDSQLch7Gb06U_XeUZ83FrQ@mail.gmail.com>

On Sun, Jun 08, 2014 at 05:04:44AM -0400, Eric Sunshine wrote:
> On Thu, Jun 5, 2014 at 2:07 AM, Heiko Voigt <hvoigt@hvoigt.net> wrote:
> > This submodule configuration cache allows us to lazily read .gitmodules
> > configurations by commit into a runtime cache which can then be used to
> > easily lookup values from it. Currently only the values for path or name
> > are stored but it can be extended for any value needed.
> >
> > [...]
> >
> > Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
> > ---
> > diff --git a/t/t7410-submodule-config.sh b/t/t7410-submodule-config.sh
> > new file mode 100755
> > index 0000000..ea453c5
> > --- /dev/null
> > +++ b/t/t7410-submodule-config.sh
> > @@ -0,0 +1,73 @@
> > +#!/bin/sh
> > +#
> > +# Copyright (c) 2014 Heiko Voigt
> > +#
> > +
> > +test_description='Test submodules config cache infrastructure
> > +
> > +This test verifies that parsing .gitmodules configuration directly
> > +from the database works.
> > +'
> > +
> > +TEST_NO_CREATE_REPO=1
> > +. ./test-lib.sh
> > +
> > +test_expect_success 'submodule config cache setup' '
> > +       mkdir submodule &&
> > +       (cd submodule &&
> > +               git init
> 
> Broken &&-chain.

Will fix. Thanks for catching.

Cheers Heiko