All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Adam Buchbinder <abuchbinder@google.com>
Cc: dash@vger.kernel.org, Adam Buchbinder <adam.buchbinder@gmail.com>
Subject: Re: [PATCH 1/2] [MAN] 0 and EXIT both work for exit traps.
Date: Wed, 11 Jun 2014 16:17:38 -0700	[thread overview]
Message-ID: <20140611231738.GH8557@google.com> (raw)
In-Reply-To: <20140611231305.GG8557@google.com>

Jonathan Nieder wrote:
> Adam Buchbinder wrote:

>> Signed-off-by: Adam Buchbinder <adam.buchbinder@gmail.com>
>> ---
>>  ChangeLog  | 4 ++++
>>  src/dash.1 | 4 +++-
>>  2 files changed, 7 insertions(+), 1 deletion(-)
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Mph, on second thought this still seems to have a trailing tab
for some reason.  Patch 2 seems to be missing the change to
src/dash.1.  Here are the same patches again with that fixed.

Thanks,

Adam Buchbinder (1):
  [MAN] 0 and EXIT both work for exit traps.

Jonathan Nieder (1):
  [MAN] Clarify "trap '' signals" syntax in manual page

 ChangeLog  | 4 ++++
 src/dash.1 | 8 ++++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

  reply	other threads:[~2014-06-11 23:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11 23:08 [PATCH 1/2] [MAN] 0 and EXIT both work for exit traps Adam Buchbinder
2014-06-11 23:08 ` [PATCH 2/2] [MAN] Clarify "trap '' signals" syntax in man page Adam Buchbinder
2014-06-11 23:13 ` [PATCH 1/2] [MAN] 0 and EXIT both work for exit traps Jonathan Nieder
2014-06-11 23:17   ` Jonathan Nieder [this message]
2014-06-11 23:20     ` Jonathan Nieder
2014-09-26 14:21       ` Herbert Xu
2014-06-11 23:21     ` [PATCH 2/2] [MAN] Clarify "trap '' signals" syntax in manual page Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140611231738.GH8557@google.com \
    --to=jrnieder@gmail.com \
    --cc=abuchbinder@google.com \
    --cc=adam.buchbinder@gmail.com \
    --cc=dash@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.