All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] Add ctrlc_ignore environment variable to ignore Ctrl-C
Date: Thu, 12 Jun 2014 08:22:28 +0200	[thread overview]
Message-ID: <20140612062228.337103803E2@gemini.denx.de> (raw)
In-Reply-To: <CAPnjgZ3p20664FOc9vPaV=z3dEdv7T=mmLpwbSy8NjiFUP2A8w@mail.gmail.com>

Dear Simon,

In message <CAPnjgZ3p20664FOc9vPaV=z3dEdv7T=mmLpwbSy8NjiFUP2A8w@mail.gmail.com> you wrote:
> 
> > - This buffering of data in this patch is intended to solve a specific
> >   problem that could be avoided by more clever test scripts.  Instead
> >   of just dumping an endless stream of characters to the serial
> >   console independent of what U-Boot is doing, one should always wit
> >   for the next CLI prompt before sending the next command.  Tools like
> >   "expect" can do this easily.
> 
> Agreed it could be done that way, but it is so much easier if U-Boot
> can behave in a simple way with input. We may end up with more
> complicated test scripts although I would prefer that we focus on unit
> tests a bit more.

As long as we don't support interrupts on all architectures and
convert at least the UART drivers to use an interrupt driven mode we
will always face the situation that U-Boot will bi strictly single-
threaded and just does not read any input while doing something else,
like running a command.

So all test scripts should consider this behaviour of the input
interface.  If they send more than one line of text to input, they
should do it line by line, and always wait for the CLI prompt first.

Yes, this is inconvenient.

> Fair enough, I don't disagree with this at all. The use case for
> buffering is when you have the LCD running and it is quite slow to
> print characters. You then can't type quickly at the keyboard -
> U-Boot just gets behind. It happens on snow and seaboard when the
> caches are off.

Heh.  So the obvious solution is to turn the caches on :-)

No - I do understand what you want, and why, and I agree that it would
be nice to have.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I can type faster than I can move a  mouse,  so  I  find  menu-driven
drawing packages time consuming and frustrating.      - W. R. Stevens

  reply	other threads:[~2014-06-12  6:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05 18:27 [U-Boot] [PATCH 0/4] Improve/fix tests for commands and trace Simon Glass
2014-06-05 18:27 ` [U-Boot] [PATCH 1/4] Reactivate the tracing feature Simon Glass
2014-06-10  4:47   ` Masahiro Yamada
2014-06-12  3:42     ` Simon Glass
2014-06-12  3:50       ` Simon Glass
2014-06-13  2:56         ` Masahiro Yamada
2014-06-14 20:34           ` Simon Glass
2014-06-13  2:56       ` Masahiro Yamada
2014-06-05 18:27 ` [U-Boot] [PATCH 2/4] Add ctrlc_ignore environment variable to ignore Ctrl-C Simon Glass
2014-06-05 21:43   ` Wolfgang Denk
2014-06-06 20:01     ` Simon Glass
2014-06-06 22:10       ` Wolfgang Denk
2014-06-08  4:01         ` Simon Glass
2014-06-10  5:08           ` Wolfgang Denk
2014-06-12  4:35             ` Simon Glass
2014-06-12  5:03               ` Wolfgang Denk
2014-06-12  5:36                 ` Simon Glass
2014-06-12  6:22                   ` Wolfgang Denk [this message]
2014-06-05 18:27 ` [U-Boot] [PATCH 3/4] test: Remove tabs from trace test Simon Glass
2014-06-05 18:27 ` [U-Boot] [PATCH 4/4] test: Add a test for command repeat Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140612062228.337103803E2@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.