From: David Sterba <dsterba@suse.cz>
To: Julien Muchembled <jm@jmuchemb.eu>
Cc: Adam Buchbinder <abuchbinder@google.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Add some simple end-to-end tests for btrfs-convert.
Date: Thu, 12 Jun 2014 11:21:41 +0200 [thread overview]
Message-ID: <20140612092141.GK1903@twin.jikos.cz> (raw)
In-Reply-To: <5388CD3A.6090600@jmuchemb.eu>
On Fri, May 30, 2014 at 08:26:02PM +0200, Julien Muchembled wrote:
> Le 05/21/14 19:20, Adam Buchbinder a écrit :
> > + # 256MB is the smallest acceptable btrfs image.
> > + dd if=/dev/zero of=$here/test.img bs=1024 count=$((256*1024)) \
> > + >> convert-tests-results.txt 2>&1 || _fail "dd failed"
>
> What about using a sparse file to speed up the test and be nicer with the underlying storage ?
> For example:
> truncate -s 256M $here/test.img
>
> Because this does not reset test.img with zeros, one may want to the
> rm -f test.img
> line at the beginning of the test function.
Yes, good idea. Patches welcome. Thanks.
prev parent reply other threads:[~2014-06-12 9:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 17:20 [PATCH] Add some simple end-to-end tests for btrfs-convert Adam Buchbinder
2014-05-28 17:30 ` David Sterba
2014-05-30 18:26 ` Julien Muchembled
2014-06-12 9:21 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140612092141.GK1903@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=abuchbinder@google.com \
--cc=jm@jmuchemb.eu \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.