From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wv6Qw-0003fr-Dj for qemu-devel@nongnu.org; Thu, 12 Jun 2014 10:57:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wv6Qo-0006wC-Uw for qemu-devel@nongnu.org; Thu, 12 Jun 2014 10:56:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18723) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wv6Qo-0006vw-Ls for qemu-devel@nongnu.org; Thu, 12 Jun 2014 10:56:46 -0400 Date: Thu, 12 Jun 2014 17:57:09 +0300 From: "Michael S. Tsirkin" Message-ID: <20140612145709.GA24144@redhat.com> References: <1402242359-8566-1-git-send-email-mst@redhat.com> <87a99izg52.fsf@blackfin.pond.sub.org> <20140612083209.GA22189@redhat.com> <87ppietcyg.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ppietcyg.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH applied] ich: get rid of spaces in type name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Igor Mammedov , qemu-devel@nongnu.org, Anthony Liguori On Thu, Jun 12, 2014 at 04:33:11PM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Jun 12, 2014 at 10:27:53AM +0200, Markus Armbruster wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > Names with spaces in them are nasty, let's not go there. > >> > >> Yes, they are, but please use '-' instead of '_'. I can see just a few > >> devices with '_' in their name, but more than a hundred with '-'. > > > > No problem, I made this change. > > Result pushed to the pci branch, pls take a look there. > > > > Thanks! > > The change is good, but I have more questions now. > > What about "ICH9 SMB" in hw/i2c/smbus_ich9.c? Same thing I guess. I noticed the other one because Igor touched it in his patch. Pls go ahead and submit a patch. > Technically, device names are ABI. These two are onboard devices, so > changing their names can't break -device / device_add use. It still > could break -global use. Do we care? > > If yes, the obvious fix is to keep the old name as alias. I don't think we care practically, but sure, go ahead and submit the patch if you feel like it. -- MST