All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jimmy P <jimmyp11f155@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Sachin Kamat <sachin.kamat@linaro.org>,
	linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: fix coding style
Date: Thu, 12 Jun 2014 09:10:50 -0700	[thread overview]
Message-ID: <20140612161050.GA12586@kroah.com> (raw)
In-Reply-To: <1402566163-9860-1-git-send-email-jimmyp11f155@gmail.com>

On Thu, Jun 12, 2014 at 05:42:43PM +0800, Jimmy P wrote:
> This patch fixes coding style errors reported by checkpatch.pl for
> lines that was over 80 chars long. The macro value shoud be put in () as
> well.
> 
> Signed-off-by: Jimmy P <jimmyp11f155@gmail.com>

We need a "real" or "full" name here for the signed-off-by: line, please
read Documentation/SubmittingPatches for the full details as to what
this line means and why we need that.

Also, this patch does multiple things, please break it up into different
patches, each only doing one specific thing.

thanks,

greg k-h

  reply	other threads:[~2014-06-12 16:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-12  9:42 [PATCH] staging: iio: fix coding style Jimmy P
2014-06-12 16:10 ` Greg Kroah-Hartman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-06-13  5:56 Jimmy Picard
2014-06-14 15:15 ` Jonathan Cameron
2014-04-09 18:09 Joel Porquet
2014-04-12 17:28 ` Jonathan Cameron
2014-04-14  9:40   ` Dan O'Donovan
2014-04-14 13:59   ` Joël Porquet
2014-04-14 16:10     ` Jonathan Cameron
2014-06-14 15:21 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140612161050.GA12586@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=jic23@kernel.org \
    --cc=jimmyp11f155@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.