From: Chris Wilson <chris@chris-wilson.co.uk>
To: "Volkin, Bradley D" <bradley.d.volkin@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Handle concurrent GTT faults gracefully
Date: Thu, 12 Jun 2014 18:36:04 +0100 [thread overview]
Message-ID: <20140612173604.GA22103@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <20140612171058.GA28788@bdvolkin-ubuntu-desktop>
On Thu, Jun 12, 2014 at 10:10:58AM -0700, Volkin, Bradley D wrote:
> On Thu, Jun 12, 2014 at 03:13:14PM +0100, Chris Wilson wrote:
> > + /* Check if a second thread completed the prefaulting for us */
> > + if (obj->fault_mappable && pte_exists(vma, vma->vm_start))
> > + goto unlock;
> > +
>
> We only set fault_mappable if we successfully remapped the whole range and clear
> it on unmapping the whole range, so do we need the additional pte_exists() check?
Yes. You have you have to consider that we can have multiple vma
pointing to the same object. See i-g-t/gem_mmap_gtt/read-write-distinct.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2014-06-12 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 14:13 [PATCH] drm/i915: Handle concurrent GTT faults gracefully Chris Wilson
2014-06-12 14:32 ` Chris Wilson
2014-06-12 17:10 ` Volkin, Bradley D
2014-06-12 17:36 ` Chris Wilson [this message]
2014-06-13 14:17 ` Volkin, Bradley D
2014-06-13 14:40 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140612173604.GA22103@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=bradley.d.volkin@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.