From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752793AbaFMH0L (ORCPT ); Fri, 13 Jun 2014 03:26:11 -0400 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:58862 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750852AbaFMH0I (ORCPT ); Fri, 13 Jun 2014 03:26:08 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 99.127.230.128 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/E6omFEX9Jg3XnhRRmJx8W Date: Fri, 13 Jun 2014 00:25:50 -0700 From: Tony Lindgren To: Roger Quadros Cc: dwmw2@infradead.org, computersforpeace@gmail.com, kyungmin.park@samsung.com, pekon@ti.com, ezequiel.garcia@free-electrons.com, javier@dowhile0.org, nsekhar@ti.com, linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/36] ARM: OMAP2+: gpmc: Allow drivers to reconfigure GPMC settings & timings Message-ID: <20140613072550.GM17845@atomide.com> References: <1402477001-31132-1-git-send-email-rogerq@ti.com> <1402477001-31132-15-git-send-email-rogerq@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1402477001-31132-15-git-send-email-rogerq@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Roger Quadros [140611 01:58]: > Some devices (e.g. TUSB6010, omap-onenand) need to reconfigure the GPMC > timings in order to operate with different peripheral clock frequencies. > Introduce omap_gpmc_retime() to allow them to do that. The driver > needs to pass the chips select number, GPMC settings and Device timings to > omap_gpmc_retime(). > > NOTE: Device tree and board code must still pass the most conservative > timings to GPMC so that the device can be probed by the respective driver. > e.g. Onenand must operate in asynchronous mode at bootup. The device driver > can then request for more optimal timings via omap_gpmc_retime(). Hmm but many of the devices are Linux generic like sms91x and 8250 so it's not nice to start stuffing omap bus specific data there. I wonder if we should just keep device specific gpmc-smc91x.c etc in drivers/memory? Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 13 Jun 2014 00:25:50 -0700 From: Tony Lindgren To: Roger Quadros Subject: Re: [PATCH 14/36] ARM: OMAP2+: gpmc: Allow drivers to reconfigure GPMC settings & timings Message-ID: <20140613072550.GM17845@atomide.com> References: <1402477001-31132-1-git-send-email-rogerq@ti.com> <1402477001-31132-15-git-send-email-rogerq@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1402477001-31132-15-git-send-email-rogerq@ti.com> Cc: devicetree@vger.kernel.org, linux-omap@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, linux-mtd@lists.infradead.org, pekon@ti.com, ezequiel.garcia@free-electrons.com, javier@dowhile0.org, computersforpeace@gmail.com, dwmw2@infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , * Roger Quadros [140611 01:58]: > Some devices (e.g. TUSB6010, omap-onenand) need to reconfigure the GPMC > timings in order to operate with different peripheral clock frequencies. > Introduce omap_gpmc_retime() to allow them to do that. The driver > needs to pass the chips select number, GPMC settings and Device timings to > omap_gpmc_retime(). > > NOTE: Device tree and board code must still pass the most conservative > timings to GPMC so that the device can be probed by the respective driver. > e.g. Onenand must operate in asynchronous mode at bootup. The device driver > can then request for more optimal timings via omap_gpmc_retime(). Hmm but many of the devices are Linux generic like sms91x and 8250 so it's not nice to start stuffing omap bus specific data there. I wonder if we should just keep device specific gpmc-smc91x.c etc in drivers/memory? Regards, Tony