From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [PATCH] drm/i915: Attach a PSR property on eDP
Date: Sat, 14 Jun 2014 09:48:46 +0100
Message-ID: <20140614084846.GB4537@strange.amr.corp.intel.com>
References: <1402691284-24458-1-git-send-email-chris@chris-wilson.co.uk>
 <1402691567-24531-1-git-send-email-chris@chris-wilson.co.uk>
 <20140614081734.GC3160@strange.amr.corp.intel.com>
 <20140614082620.GA21605@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTP id 062A26E06B
 for <intel-gfx@lists.freedesktop.org>; Sat, 14 Jun 2014 01:48:48 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140614082620.GA21605@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Sat, Jun 14, 2014 at 09:26:20AM +0100, Chris Wilson wrote:
> On Sat, Jun 14, 2014 at 09:17:34AM +0100, Damien Lespiau wrote:
> > On Fri, Jun 13, 2014 at 09:32:47PM +0100, Chris Wilson wrote:
> > > Let userspace know the status of Panel Self-Refresh by virtue of a
> > > property on the appropriate connector.
> > > 
> > > v2: Only attach the property if the driver is capable of PSR.
> > > 
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > 
> > Can we have an updated property table in Documentation/DocBook/drm.tmpl
> > as well?
> 
> If you care to give me a taylor made example... ;-)

That prompted me wondering if it should be a DRM property instead, but there's
no harm in keeping it i915 specific until there's a second user.

$ git diff
diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
index 7df3134..3bb7ecb 100644
--- a/Documentation/DocBook/drm.tmpl
+++ b/Documentation/DocBook/drm.tmpl
@@ -2648,7 +2648,7 @@ void intel_crt_init(struct drm_device *dev)
	<td valign="top" >TBD</td>
	</tr>
	<tr>
-	<td rowspan="21" valign="top" >i915</td>
+	<td rowspan="22" valign="top" >i915</td>
	<td rowspan="3" valign="top" >Generic</td>
	<td valign="top" >"Broadcast RGB"</td>
	<td valign="top" >ENUM</td>
@@ -2799,6 +2799,14 @@ void intel_crt_init(struct drm_device *dev)
	<td valign="top" >TBD</td>
	</tr>
	<tr>
+	<td valign="top" >eDP</td>
+	<td valign="top" >"PSR"</td>
+	<td valign="top" >ENUM | IMMUTABLE</td>
+	<td valign="top" >{ "Idle", "Active" }</td>
+	<td valign="top" >Connector</td>
+	<td valign="top" >Whether PSR is currently active or not</td>
+	</tr>
+	<tr>
	<td rowspan="3" valign="top" >CDV gma-500</td>
	<td rowspan="3" valign="top" >Generic</td>
	<td valign="top" >"Broadcast RGB"</td>

(It even renders correctly!)

-- 
Damien