All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>,
	linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Corey Ashford <cjashfor@linux.vnet.ibm.com>,
	David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [RFC/PATCH] perf tools: Fix segfault in cumulative.callchain report
Date: Sun, 15 Jun 2014 18:34:05 +0200	[thread overview]
Message-ID: <20140615163404.GA1159@krava.brq.redhat.com> (raw)
In-Reply-To: <1402836391.1684.9.camel@leonhard>

On Sun, Jun 15, 2014 at 09:46:31PM +0900, Namhyung Kim wrote:
> Hi Jiri,
> 
> 2014-06-15 (일), 10:35 +0200, Jiri Olsa:
> > heya,
> > not completely sure this is what we want to do, but have no
> > streght to dive into annotation code ;-)
> 
> Currently, cumulative entries do not accounts annotation info so
> annotation only works for normal entries.  I'm not sure we should
> support it or not, but anyway it also needs some updates on the
> annotation code IMHO.
> 
> So I'm okay with disabling annotation on pure cumulative entries.

is that an ack? ;-)

thanks,
jirka

  reply	other threads:[~2014-06-15 16:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-15  8:35 [RFC/PATCH] perf tools: Fix segfault in cumulative.callchain report Jiri Olsa
2014-06-15 12:46 ` Namhyung Kim
2014-06-15 16:34   ` Jiri Olsa [this message]
2014-06-16 13:14     ` Namhyung Kim
2014-06-19 15:36       ` Arnaldo Carvalho de Melo
2014-06-25  5:52 ` [tip:perf/core] " tip-bot for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140615163404.GA1159@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=cjashfor@linux.vnet.ibm.com \
    --cc=dsahern@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.