From: Lee Jones <lee.jones@linaro.org>
To: Dave Jones <davej@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
mporter@linaro.org
Subject: Re: regulator: bcm590xx: Add support for regulators on secondary I2C slave
Date: Mon, 16 Jun 2014 09:06:01 +0100 [thread overview]
Message-ID: <20140616080601.GE14323@lee--X1> (raw)
In-Reply-To: <20140610152255.GA20737@redhat.com>
On Tue, 10 Jun 2014, Dave Jones wrote:
> On Tue, Jun 03, 2014 at 07:29:10PM +0000, Linux Kernel wrote:
> > Gitweb: http://git.kernel.org/linus/;a=commit;h=c6466950e917890be3050171f6745ccb9d91d35f
> > Commit: c6466950e917890be3050171f6745ccb9d91d35f
> > Parent: 9e1e726311830bc5b8b568d5178f6a52c357fb6e
> > Refname: refs/heads/next
> > Author: Matt Porter <mporter@linaro.org>
> > AuthorDate: Wed Apr 23 19:21:32 2014 -0400
> > Committer: Lee Jones <lee.jones@linaro.org>
> > CommitDate: Wed May 21 10:40:16 2014 +0100
> >
> > regulator: bcm590xx: Add support for regulators on secondary I2C slave
> >
> > The bcm590xx MFD driver now exposes a secondary regmap descriptor
> > making the registers for regulators on the secondary I2C slave address
> > available. Add support for GPLDO1-6 and VBUS regulators found within
> > this register range.
>
> > -#define BCM590XX_NUM_REGS 20
> > +#define BCM590XX_NUM_REGS 27
>
> Coverity picked up that this change has introduced a out of bounds read.
> The loop in bcm590xx_probe iterates from 0 to NUM_REGS,
> but the bcm590xx_regs struct it iterates over using the ptr 'info' is only 26
> elements.
Nice little tool. :)
Matt, I assume you'll fix this yourself?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-06-16 8:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140603192910.BB56066103D@gitolite.kernel.org>
2014-06-10 15:22 ` regulator: bcm590xx: Add support for regulators on secondary I2C slave Dave Jones
2014-06-16 8:06 ` Lee Jones [this message]
2014-06-17 15:38 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140616080601.GE14323@lee--X1 \
--to=lee.jones@linaro.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mporter@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.