From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754699AbaFPIop (ORCPT ); Mon, 16 Jun 2014 04:44:45 -0400 Received: from mail-ig0-f173.google.com ([209.85.213.173]:49825 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754588AbaFPIoe (ORCPT ); Mon, 16 Jun 2014 04:44:34 -0400 Date: Mon, 16 Jun 2014 09:44:27 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: Samuel Ortiz , Mark Brown , Mike Turquette , Liam Girdwood , Alessandro Zummo , Kukjin Kim , Doug Anderson , Olof Johansson , Sjoerd Simons , Daniel Stone , Tomeu Vizoso , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] clk: Add driver for Maxim 77802 PMIC clocks Message-ID: <20140616084427.GG14323@lee--X1> References: <1402306670-17041-1-git-send-email-javier.martinez@collabora.co.uk> <1402306670-17041-4-git-send-email-javier.martinez@collabora.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1402306670-17041-4-git-send-email-javier.martinez@collabora.co.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with > Low Jitter Mode. This patch adds support for these two clocks. > > Signed-off-by: Javier Martinez Canillas > --- > .../devicetree/bindings/clock/maxim,max77802.txt | 40 ++++ > drivers/clk/Kconfig | 6 + > drivers/clk/Makefile | 1 + > drivers/clk/clk-max77802.c | 253 +++++++++++++++++++++ > drivers/mfd/max77802.c | 3 + > include/dt-bindings/clock/maxim,max77802.h | 22 ++ > 6 files changed, 325 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/maxim,max77802.txt > create mode 100644 drivers/clk/clk-max77802.c > create mode 100644 include/dt-bindings/clock/maxim,max77802.h [...] > diff --git a/drivers/mfd/max77802.c b/drivers/mfd/max77802.c > index 59696dd..33e8023 100644 > --- a/drivers/mfd/max77802.c > +++ b/drivers/mfd/max77802.c > @@ -35,6 +35,9 @@ > > static const struct mfd_cell max77802_devs[] = { > { .name = "max77802-pmic", }, > +#if defined(CONFIG_COMMON_CLK_MAX77802) No, don't do that. If COMMON_CLK_MAX77802 is not defined it just won't be matched, which is enough to ensure it won't be probed. > + { .name = "max77802-clk", }, > +#endif > }; [...] -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Mon, 16 Jun 2014 09:44:27 +0100 Subject: [PATCH 3/5] clk: Add driver for Maxim 77802 PMIC clocks In-Reply-To: <1402306670-17041-4-git-send-email-javier.martinez@collabora.co.uk> References: <1402306670-17041-1-git-send-email-javier.martinez@collabora.co.uk> <1402306670-17041-4-git-send-email-javier.martinez@collabora.co.uk> Message-ID: <20140616084427.GG14323@lee--X1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with > Low Jitter Mode. This patch adds support for these two clocks. > > Signed-off-by: Javier Martinez Canillas > --- > .../devicetree/bindings/clock/maxim,max77802.txt | 40 ++++ > drivers/clk/Kconfig | 6 + > drivers/clk/Makefile | 1 + > drivers/clk/clk-max77802.c | 253 +++++++++++++++++++++ > drivers/mfd/max77802.c | 3 + > include/dt-bindings/clock/maxim,max77802.h | 22 ++ > 6 files changed, 325 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/maxim,max77802.txt > create mode 100644 drivers/clk/clk-max77802.c > create mode 100644 include/dt-bindings/clock/maxim,max77802.h [...] > diff --git a/drivers/mfd/max77802.c b/drivers/mfd/max77802.c > index 59696dd..33e8023 100644 > --- a/drivers/mfd/max77802.c > +++ b/drivers/mfd/max77802.c > @@ -35,6 +35,9 @@ > > static const struct mfd_cell max77802_devs[] = { > { .name = "max77802-pmic", }, > +#if defined(CONFIG_COMMON_CLK_MAX77802) No, don't do that. If COMMON_CLK_MAX77802 is not defined it just won't be matched, which is enough to ensure it won't be probed. > + { .name = "max77802-clk", }, > +#endif > }; [...] -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog