From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Kiper Subject: Re: [PATCH v5 4/7] xen: Put EFI machinery in place Date: Mon, 16 Jun 2014 21:06:23 +0200 Message-ID: <20140616190623.GI3463__48644.4662245505$1402945733$gmane$org@olila.local.net-space.pl> References: <1402678823-24589-1-git-send-email-daniel.kiper@oracle.com> <1402678823-24589-5-git-send-email-daniel.kiper@oracle.com> <539EDC5D.4010207@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WwcF4-0005Af-N1 for xen-devel@lists.xenproject.org; Mon, 16 Jun 2014 19:06:54 +0000 Content-Disposition: inline In-Reply-To: <539EDC5D.4010207@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel Cc: mjg59@srcf.ucam.org, jeremy@goop.org, linux-efi@vger.kernel.org, ian.campbell@citrix.com, andrew.cooper3@citrix.com, x86@kernel.org, linux-kernel@vger.kernel.org, matt.fleming@intel.com, tglx@linutronix.de, jbeulich@suse.com, hpa@zytor.com, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, mingo@redhat.com, stefano.stabellini@eu.citrix.com, eshelton@pobox.com List-Id: xen-devel@lists.xenproject.org On Mon, Jun 16, 2014 at 01:00:29PM +0100, David Vrabel wrote: > On 13/06/14 18:00, Daniel Kiper wrote: > > > > v5 - suggestions/fixes: > > Put after a --- marker. Why? You mean: --- v5 - suggestions/fixes: ... > > +static efi_char16_t vendor[100] __initdata; > > Why 100? Well... Quite arbitrary value. The same thing is used in arch/x86/platform/efi/efi.c:efi_init(). Sadly UEFI sepec says nothing about maximum vendor name length. Daniel