From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from bombadil.infradead.org ([198.137.202.9]:38824 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932588AbaFQNw4 (ORCPT ); Tue, 17 Jun 2014 09:52:56 -0400 Date: Tue, 17 Jun 2014 06:52:55 -0700 From: Christoph Hellwig To: Jeff Layton Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org, hch@infradead.org Subject: Re: [PATCH v2 2/4] nfsd: clean up sparse endianness warnings in nfscache.c Message-ID: <20140617135255.GB13980@infradead.org> References: <1403005454-7319-1-git-send-email-jlayton@primarydata.com> <1403005454-7319-3-git-send-email-jlayton@primarydata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1403005454-7319-3-git-send-email-jlayton@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Tue, Jun 17, 2014 at 07:44:12AM -0400, Jeff Layton wrote: > We currently hash the XID to determine a hash bucket to use for the > reply cache entry, which is fed into hash_32 without byte-swapping it. > Add __force to make sparse happy, and add some comments to explain > why. Would seem simpler to me to simply do the byteswap, but.. Reviewed-by: Christoph Hellwig