From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933600AbaFQT01 (ORCPT ); Tue, 17 Jun 2014 15:26:27 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:58132 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932657AbaFQT0Z (ORCPT ); Tue, 17 Jun 2014 15:26:25 -0400 Date: Tue, 17 Jun 2014 15:26:21 -0400 From: Tejun Heo To: Li Zefan Cc: LKML , Cgroups Subject: Re: [PATCH 1/5] cgroup: fix broken css_has_online_children() Message-ID: <20140617192621.GO31819@htj.dyndns.org> References: <53994943.60703@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53994943.60703@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 12, 2014 at 02:31:31PM +0800, Li Zefan wrote: > After running: > > # mount -t cgroup cpu xxx /cgroup && mkdir /cgroup/sub && \ > rmdir /cgroup/sub && umount /cgroup > > I found the cgroup root still existed: > > # cat /proc/cgroups > #subsys_name hierarchy num_cgroups enabled > cpuset 0 1 1 > cpu 1 1 1 > ... > > It turned out css_has_online_children() is broken. > > Signed-off-by: Li Zefan Applied to cgroup/for-3.16-fixes. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 1/5] cgroup: fix broken css_has_online_children() Date: Tue, 17 Jun 2014 15:26:21 -0400 Message-ID: <20140617192621.GO31819@htj.dyndns.org> References: <53994943.60703@huawei.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=KiqizsuaM+sH2YKSOY0SZx3qjmhhQegGmzzxfKVWEIw=; b=q7gBGclKVliTTvPLQglUv34iKq8dvHhThkPMq0gLnpN1OONEwutTZTPMeKBSDhxg1a AKEEj0rvEt+6SGqBdpCgWUtn+Erl9/22B4llQ5tkWhHiJHu+HzVnJL14Hxklda/yIpnd uEh6P8gi4FA1ADsxIAmk6RMIrt0q3KZ8H5iYMPoxskyBKQHYjCZ0SMVIW7RC8vcCzsW5 P7xm058vUeiJufUmFO8kaBcpC7LJcpNj5h01qzVZfsToI9cISs3xp6Ua8LT6h8JWzv+L Y9GXb9oRv5gohB1xXHp3ng+gGHZgw3RL+HpkFLCoKpUUKLFGFZs38l3TWOpirFLboIhC 7hbQ== Content-Disposition: inline In-Reply-To: <53994943.60703-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Li Zefan Cc: LKML , Cgroups On Thu, Jun 12, 2014 at 02:31:31PM +0800, Li Zefan wrote: > After running: > > # mount -t cgroup cpu xxx /cgroup && mkdir /cgroup/sub && \ > rmdir /cgroup/sub && umount /cgroup > > I found the cgroup root still existed: > > # cat /proc/cgroups > #subsys_name hierarchy num_cgroups enabled > cpuset 0 1 1 > cpu 1 1 1 > ... > > It turned out css_has_online_children() is broken. > > Signed-off-by: Li Zefan Applied to cgroup/for-3.16-fixes. Thanks. -- tejun