From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934025AbaFRIss (ORCPT ); Wed, 18 Jun 2014 04:48:48 -0400 Received: from mail-ie0-f175.google.com ([209.85.223.175]:52549 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933366AbaFRIso (ORCPT ); Wed, 18 Jun 2014 04:48:44 -0400 Date: Wed, 18 Jun 2014 09:48:38 +0100 From: Lee Jones To: Nikita Yushchenko Cc: Grant Likely , Rob Herring , Benjamin Herrenschmidt , Thomas Gleixner , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, lugovskoy@dev.rtsoft.ru Subject: Re: [PATCH 11/21] mfd: use devm_irq_of_parse_and_map() where appropriate Message-ID: <20140618084838.GR21030@lee--X1> References: <1401880402-30091-1-git-send-email-nyushchenko@dev.rtsoft.ru> <1401880402-30091-12-git-send-email-nyushchenko@dev.rtsoft.ru> <20140617151226.GM29841@lee--X1> <53A0606C.6030400@dev.rtsoft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <53A0606C.6030400@dev.rtsoft.ru> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Jun 2014, Nikita Yushchenko wrote: > 17.06.2014 19:12, Lee Jones пишет: > >>From: Nikita Yushchenko > >> > >>This avoids leak of IRQ mapping on error paths, and makes it possible > >>to use devm_request_irq() without facing unmap-while-handler-installed > >>issues. > >> > >>Signed-off-by: Nikita Yushchenko > >>--- > >> drivers/mfd/max8997.c | 4 +++- > >> drivers/mfd/max8998.c | 4 +++- > >> 2 files changed, 6 insertions(+), 2 deletions(-) > > > >Applied, thanks. > > Hmm... probably it was too early to apply this? I was just going > to prepare v2, based on discussion... Which discussion? > Also, applying only 11/21, without 01/21, will just cause build errors ... CC'ing me on this patch alone when you know you have build dependencies on other patches in the set is a bad idea. Failing to mention that you wanted the patch to be handled in a special and/or unconventional way is an even worse idea. How are you expecting this patch(-set) to be handled? > Confused. Likewise! -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog