From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [PATCH v2 0/2] Fix issues with VFIO Date: Wed, 18 Jun 2014 09:44:18 -0400 Message-ID: <20140618134417.GA3301@localhost.localdomain> References: <4bf447650cc99e316e6427e3a1c134dd417af4ec.1402996488.git.anatoly.burakov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev-VfR2kkLFssw@public.gmane.org To: Anatoly Burakov Return-path: Content-Disposition: inline In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Wed, Jun 18, 2014 at 02:07:17PM +0100, Anatoly Burakov wrote: > This patchset fixes an issue with VFIO where DPDK initialization could > fail even if the user didn't want to use VFIO in the first place. Also, > more verbose and descriptive error messages were added to VFIO code, for > example distinguishing between a failed ioctl() call and an unsupported > VFIO API version. > > Anatoly Burakov (2): > vfio: open VFIO container at startup rather than during init > vfio: more verbose error messages > You still need a changelog entry with each patch (the cover letter doesn't get included with the patches in git). You also probably want to mention that the second patch also fixes a case in which syscall errors are erroneously treated as a success case Neil > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 63 ++++++++++++++++-------------- > 1 file changed, 34 insertions(+), 29 deletions(-) > > -- > 1.8.1.4 > >