From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH v5 5/7] arch/x86: Replace plain strings with constants Date: Wed, 18 Jun 2014 14:56:18 +0100 Message-ID: <20140618135618.GI24049__41966.2014967345$1403099884$gmane$org@console-pimps.org> References: <1402678823-24589-1-git-send-email-daniel.kiper@oracle.com> <1402678823-24589-6-git-send-email-daniel.kiper@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WxGLd-0003ui-Uv for xen-devel@lists.xenproject.org; Wed, 18 Jun 2014 13:56:22 +0000 Received: by mail-wg0-f68.google.com with SMTP id x13so251639wgg.3 for ; Wed, 18 Jun 2014 06:56:20 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1402678823-24589-6-git-send-email-daniel.kiper@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Daniel Kiper Cc: mjg59@srcf.ucam.org, jeremy@goop.org, linux-efi@vger.kernel.org, ian.campbell@citrix.com, andrew.cooper3@citrix.com, x86@kernel.org, linux-kernel@vger.kernel.org, matt.fleming@intel.com, tglx@linutronix.de, david.vrabel@citrix.com, jbeulich@suse.com, hpa@zytor.com, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, mingo@redhat.com, stefano.stabellini@eu.citrix.com, eshelton@pobox.com List-Id: xen-devel@lists.xenproject.org On Fri, 13 Jun, at 07:00:21PM, Daniel Kiper wrote: > v5 - suggestions/fixes: > - do not change indentation > (suggested by Matt Fleming). > > Signed-off-by: Daniel Kiper > --- > arch/x86/kernel/setup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Looks good, but it's customary to have at least one line after the patch title. Even something as trivial as, "We've got constants, so let's use them instead of hard-coded values." -- Matt Fleming, Intel Open Source Technology Center