From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH v5 6/7] arch/x86: Remove redundant set_bit() call Date: Wed, 18 Jun 2014 15:09:53 +0100 Message-ID: <20140618140953.GL24049__13546.3892519057$1403100711$gmane$org@console-pimps.org> References: <1402678823-24589-1-git-send-email-daniel.kiper@oracle.com> <1402678823-24589-7-git-send-email-daniel.kiper@oracle.com> <20140618135637.GJ24049@console-pimps.org> <20140618140101.GC4651@laptop.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WxGYm-0006Ms-Mg for xen-devel@lists.xenproject.org; Wed, 18 Jun 2014 14:09:56 +0000 Received: by mail-wg0-f68.google.com with SMTP id x13so256664wgg.7 for ; Wed, 18 Jun 2014 07:09:55 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140618140101.GC4651@laptop.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: mjg59@srcf.ucam.org, jeremy@goop.org, linux-efi@vger.kernel.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, Daniel Kiper , x86@kernel.org, linux-kernel@vger.kernel.org, matt.fleming@intel.com, tglx@linutronix.de, david.vrabel@citrix.com, jbeulich@suse.com, hpa@zytor.com, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, mingo@redhat.com, eshelton@pobox.com List-Id: xen-devel@lists.xenproject.org On Wed, 18 Jun, at 10:01:01AM, Konrad Rzeszutek Wilk wrote: > On Wed, Jun 18, 2014 at 02:56:37PM +0100, Matt Fleming wrote: > > On Fri, 13 Jun, at 07:00:22PM, Daniel Kiper wrote: > > > Remove redundant set_bit(EFI_SYSTEM_TABLES, &efi.flags) call. > > > It is executed earlier in efi_systab_init(). > > > > > > Signed-off-by: Daniel Kiper > > > --- > > > arch/x86/platform/efi/efi.c | 2 -- > > > 1 file changed, 2 deletions(-) > > > > Looks good! > > Is that an Acked-by or Reviewed-by ? :-) Since I assumed this series would be going through my tree, I didn't think it mattered. Reviewed-by: Matt Fleming -- Matt Fleming, Intel Open Source Technology Center