From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 1/2] lib, fdt: move fdtdec_get_int() out of lib/fdtdec.c
Date: Wed, 18 Jun 2014 17:09:36 -0400 [thread overview]
Message-ID: <20140618210936.GI26243@bill-the-cat> (raw)
In-Reply-To: <1402905520-15847-2-git-send-email-hs@denx.de>
On Mon, Jun 16, 2014 at 09:58:39AM +0200, Heiko Schocher wrote:
> move fdtdec_get_int() out of lib/fdtdec.c into lib/fdtdec_common.c
> as this function is also used, if CONFIG_OF_CONTROL is not
> used. Poped up on the ids8313 board using signed FIT images,
> and activating CONFIG_SYS_GENERIC_BOARD. Without this patch
> it shows on boot:
[snip]
> diff --git a/lib/Makefile b/lib/Makefile
> index 377ab13..dd87ee2 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -23,6 +23,13 @@ obj-$(CONFIG_USB_TTY) += circbuf.o
> obj-y += crc7.o
> obj-y += crc8.o
> obj-y += crc16.o
> +ifdef CONFIG_FIT
> +obj-y += fdtdec_common.o
> +else
> +ifdef CONFIG_OF_CONTROL
> +obj-y += fdtdec_common.o
> +endif
> +endif
OK, but why not:
obj-$(CONFIG_FIT) += fdtdec_common.o
obj-$(CONFIG_OF_CONTROL) += fdtdec_common.o
Since we filter out duplicates I would swear.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140618/6349754b/attachment.pgp>
next prev parent reply other threads:[~2014-06-18 21:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 7:58 [U-Boot] [PATCH v6 0/2] mpc8313: ids8313 board updates Heiko Schocher
2014-06-16 7:58 ` [U-Boot] [PATCH v6 1/2] lib, fdt: move fdtdec_get_int() out of lib/fdtdec.c Heiko Schocher
2014-06-18 21:09 ` Tom Rini [this message]
2014-06-19 4:35 ` Heiko Schocher
2014-06-20 15:53 ` Tom Rini
2014-06-16 7:58 ` [U-Boot] [PATCH v6 2/2] mpc8313: add CONFIG_SYS_GENERIC_BOARD to ids8313 board Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618210936.GI26243@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.