From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/fb-helper: Remove unnecessary list empty check in
 drm_fb_helper_debug_enter()
Date: Thu, 19 Jun 2014 10:14:18 +0200
Message-ID: <20140619081418.GQ5821@phenom.ffwll.local>
References: <1403164904-7112-1-git-send-email-Ying.Liu@freescale.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-we0-f179.google.com (mail-we0-f179.google.com
 [74.125.82.179])
 by gabe.freedesktop.org (Postfix) with ESMTP id 179A76E831
 for <dri-devel@lists.freedesktop.org>; Thu, 19 Jun 2014 01:14:26 -0700 (PDT)
Received: by mail-we0-f179.google.com with SMTP id w62so1939990wes.38
 for <dri-devel@lists.freedesktop.org>; Thu, 19 Jun 2014 01:14:26 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1403164904-7112-1-git-send-email-Ying.Liu@freescale.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Liu Ying <Ying.Liu@freescale.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Thu, Jun 19, 2014 at 04:01:44PM +0800, Liu Ying wrote:
> The following list empty check is unnecessary because we would still do nothing
> real and return 'val' if my_list is empty.
> 
> if (list_empty(&my_list))
> 	return val;
> 
> list_for_each_entry(pos, &my_list, member) {
> 	...
> }
> 
> return val;
> 
> This patch removes the unnecessary check in drm_fb_helper_debug_enter().
> 
> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>

Merged into my core-stuff branch, will send a pull to Dave for 3.17.
-Daniel

> ---
>  drivers/gpu/drm/drm_fb_helper.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index d5d8cea..eb77a2f 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -199,9 +199,6 @@ int drm_fb_helper_debug_enter(struct fb_info *info)
>  	struct drm_crtc_helper_funcs *funcs;
>  	int i;
>  
> -	if (list_empty(&kernel_fb_helper_list))
> -		return false;
> -
>  	list_for_each_entry(helper, &kernel_fb_helper_list, kernel_fb_list) {
>  		for (i = 0; i < helper->crtc_count; i++) {
>  			struct drm_mode_set *mode_set =
> -- 
> 1.7.9.5
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch