Re: [PATCH 5/5] perf tools: Add report.show-headers config file option

From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>,
	linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Corey Ashford <cjashfor@linux.vnet.ibm.com>,
	David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 5/5] perf tools: Add report.show-headers config file option
Date: Thu, 19 Jun 2014 15:02:02 +0200	[thread overview]
Message-ID: <20140619130202.GA24328@krava.brq.redhat.com> (raw)
In-Reply-To: <1403182604.1670.26.camel@leonhard>

On Thu, Jun 19, 2014 at 09:56:44PM +0900, Namhyung Kim wrote:
> Hi Jiri,
> 
> 2014-06-19 (목), 13:41 +0200, Jiri Olsa:
> > Adding report.show-headers config file option to setup
> > the appearance of the columns headers.
> > 
> > Currently columns headers are displayed by default, following
> > lines in ~/.perfconfig file will disable that:
> > 
> >   [report]
> >         show-headers = true
> 
> This also applies to perf top, right?  And it's TUI-specific.  So how
> about calling it something like "tui.show-headers"?

ook

> 
> 
> [SNIP]
> > @@ -35,6 +35,7 @@ struct symbol_conf symbol_conf = {
> >  	.demangle		= true,
> >  	.cumulate_callchain	= true,
> >  	.symfs			= "",
> > +	.show_headers		= -1,
> 
> Hmm.. why not just making it boolean and set it to true (like others)?

I need 'unset' value, otherwise I dont know if the config
option was unset by user or not touched at all

jirka