From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57303)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nchip@afflict.kos.to>) id 1WyJ1H-0000hv-P6
	for qemu-devel@nongnu.org; Sat, 21 Jun 2014 06:59:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nchip@afflict.kos.to>) id 1WyJ1D-00065H-Ad
	for qemu-devel@nongnu.org; Sat, 21 Jun 2014 06:59:39 -0400
Received: from afflict.kos.to ([92.243.29.197]:49244)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nchip@afflict.kos.to>) id 1WyJ1D-00064N-3S
	for qemu-devel@nongnu.org; Sat, 21 Jun 2014 06:59:35 -0400
Date: Sat, 21 Jun 2014 13:59:33 +0300
From: Riku Voipio <riku.voipio@iki.fi>
Message-ID: <20140621105933.GB23713@afflict.kos.to>
References: <1402849113-11402-1-git-send-email-paul@archlinuxmips.org>
	<1402849113-11402-5-git-send-email-paul@archlinuxmips.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1402849113-11402-5-git-send-email-paul@archlinuxmips.org>
Subject: Re: [Qemu-devel] [PATCH 04/16] linux-user: support SO_PASSSEC
 setsockopt option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Burton <paul@archlinuxmips.org>
Cc: Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org

On Sun, Jun 15, 2014 at 05:18:21PM +0100, Paul Burton wrote:
> Translate the SO_PASSSEC option to setsockopt to the host value &
> perform the syscall as expected, allowing use of the option by target
> programs.

Another file that is a total mess in linux-user tree.. This should be
split out to arch specific header files - but that's for another patch.
For this patch - the value for sparc SO_PASSEC should be set, since
it's different from others:

http://lxr.free-electrons.com/source/arch/sparc/include/uapi/asm/socket.h#L51

> Signed-off-by: Paul Burton <paul@archlinuxmips.org>
> ---
>  linux-user/socket.h  | 2 ++
>  linux-user/syscall.c | 3 +++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/linux-user/socket.h b/linux-user/socket.h
> index ae17959..289c6ac 100644
> --- a/linux-user/socket.h
> +++ b/linux-user/socket.h
> @@ -63,6 +63,7 @@
>      #define TARGET_SO_PEERSEC              30
>      #define TARGET_SO_SNDBUFFORCE          31
>      #define TARGET_SO_RCVBUFFORCE          33
> +    #define TARGET_SO_PASSSEC              34
>  
>      /** sock_type - Socket types
>       *
> @@ -298,6 +299,7 @@
>      #define TARGET_SO_ACCEPTCONN           30
>  
>      #define TARGET_SO_PEERSEC              31
> +    #define TARGET_SO_PASSSEC              34
>  
>  #endif
>  
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 679d165..b507f81 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -1529,6 +1529,9 @@ set_timeout:
>          case TARGET_SO_PASSCRED:
>  		optname = SO_PASSCRED;
>  		break;
> +        case TARGET_SO_PASSSEC:
> +		optname = SO_PASSSEC;
> +		break;
>          case TARGET_SO_TIMESTAMP:
>  		optname = SO_TIMESTAMP;
>  		break;
> -- 
> 2.0.0
>