From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59938)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nchip@afflict.kos.to>) id 1WyJ4T-00020S-FT
	for qemu-devel@nongnu.org; Sat, 21 Jun 2014 07:02:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nchip@afflict.kos.to>) id 1WyJ4S-00011i-PP
	for qemu-devel@nongnu.org; Sat, 21 Jun 2014 07:02:57 -0400
Received: from [2001:4b98:dc0:45:216:3eff:fe3d:166f] (port=36154
	helo=afflict.kos.to) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nchip@afflict.kos.to>) id 1WyJ4S-00011R-JM
	for qemu-devel@nongnu.org; Sat, 21 Jun 2014 07:02:56 -0400
Date: Sat, 21 Jun 2014 14:02:55 +0300
From: Riku Voipio <riku.voipio@iki.fi>
Message-ID: <20140621110255.GC23713@afflict.kos.to>
References: <1402849113-11402-1-git-send-email-paul@archlinuxmips.org>
	<1402849113-11402-8-git-send-email-paul@archlinuxmips.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1402849113-11402-8-git-send-email-paul@archlinuxmips.org>
Subject: Re: [Qemu-devel] [PATCH 07/16] linux-user: fix struct
 target_epoll_event layout for MIPS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Burton <paul@archlinuxmips.org>
Cc: Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org

On Sun, Jun 15, 2014 at 05:18:24PM +0100, Paul Burton wrote:
> MIPS requires the pad field to 64b-align the data field just as ARM
> does.

Is this true for the 64bit mips also?

> Signed-off-by: Paul Burton <paul@archlinuxmips.org>
> ---
>  linux-user/syscall_defs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
> index 69c3982..9fcb723 100644
> --- a/linux-user/syscall_defs.h
> +++ b/linux-user/syscall_defs.h
> @@ -2528,7 +2528,7 @@ typedef union target_epoll_data {
>  
>  struct target_epoll_event {
>      uint32_t events;
> -#ifdef TARGET_ARM
> +#if defined(TARGET_ARM) || defined(TARGET_MIPS)
>      uint32_t __pad;
>  #endif
>      target_epoll_data_t data;
> -- 
> 2.0.0
>