All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] packages: fix the header package name
Date: Sat, 21 Jun 2014 19:56:56 +0200	[thread overview]
Message-ID: <20140621195656.6ad08587@free-electrons.com> (raw)
In-Reply-To: <1403300466-24924-1-git-send-email-jerzy.grzegorek@trzebnica.net>

Dear Jerzy Grzegorek,

On Fri, 20 Jun 2014 23:41:06 +0200, Jerzy Grzegorek wrote:

> diff --git a/package/glibc/glibc.mk b/package/glibc/glibc.mk
> index a0077d2..6f5c53f 100644
> --- a/package/glibc/glibc.mk
> +++ b/package/glibc/glibc.mk
> @@ -1,6 +1,6 @@
>  ################################################################################
>  #
> -# glibc/eglibc
> +# (e)glibc

I'd prefer to stick with "glibc/eglibc" here. We're anyway going to
remove eglibc support soon, since eglibc 2.19 was the latest release
and the project has been declared dead.


> diff --git a/package/x11r7/xlib_libICE/xlib_libICE.mk b/package/x11r7/xlib_libICE/xlib_libICE.mk
> index dd6814e..fcb8599 100644
> --- a/package/x11r7/xlib_libICE/xlib_libICE.mk
> +++ b/package/x11r7/xlib_libICE/xlib_libICE.mk
> @@ -1,6 +1,6 @@
>  ################################################################################
>  #
> -# xlib_libICE
> +# xlib_libice

I really don't agree with all those changes to lower-case here. The
package uses capital letters in its name, so it's better for the header
to have the same capitalization.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2014-06-21 17:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-20 21:41 [Buildroot] [PATCH 1/1] packages: fix the header package name Jerzy Grzegorek
2014-06-21 17:56 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140621195656.6ad08587@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.