From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Sun, 22 Jun 2014 09:36:43 +0200 Subject: [U-Boot] [PATCH v4 0/3] mtd, ubi, ubifs: resync with Linux-3.14 In-Reply-To: <53A67ED9.2090705@denx.de> References: <1402989356-14746-1-git-send-email-hs@denx.de> <1403020481.6603.737.camel@snotra.buserror.net> <53A145F0.9010909@denx.de> <1403126679.12851.93.camel@snotra.buserror.net> <20140618214224.GJ26243@bill-the-cat> <53A2BCA4.90500@denx.de> <1403221545.12851.167.camel@snotra.buserror.net> <53A3E9DB.3040809@denx.de> <53A67ED9.2090705@denx.de> Message-ID: <20140622073643.38EB83803E9@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Heiko, In message <53A67ED9.2090705@denx.de> you wrote: > > And I have no chance to detect this difference, when using > "git am -3 ..." ... it just remains in the code ... > > I vote for copying the linux files, marking U-Boot specific code > with __UBOOT__ ... Given the complexity of the code - and of the changes added in U-Boot to the original (old) Linux code (which were done over a period of time) - I think indeed that your original approach is the better one; better both in the sense of requiring less efforts (for creating and verifying that all chanes were covered), and less risk to miss individual modifications either from the Linux or from the U-Boot side. Scott, I agree that your suggestion is what usually should work fine, but here it apparently fails in a number of places that would be time consuming to sort out - and I would expect that the same would happen again whenever we update to another new version of the Linux code base. So I think we should stick with Heiko's approach here; it documents clearly what he did, it looks complete, and it is working. I think it would be a waste of time to redo all the work, just differently. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Testing can show the presense of bugs, but not their absence. -- Edsger Dijkstra