From mboxrd@z Thu Jan 1 00:00:00 1970 From: Feng Tang Subject: Re: [Patch V4 00/42] use irqdomain to dynamically allocate IRQ for IOAPIC Date: Sun, 22 Jun 2014 23:02:12 +0800 Message-ID: <20140622150212.GB20551@feng-snb> References: <1402302011-23642-1-git-send-email-jiang.liu@linux.intel.com> <20140622084227.GA13974@gmail.com> <20140622143946.GA20551@feng-snb> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mga09.intel.com ([134.134.136.24]:37618 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487AbaFVPEe (ORCPT ); Sun, 22 Jun 2014 11:04:34 -0400 Content-Disposition: inline In-Reply-To: <20140622143946.GA20551@feng-snb> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Ingo Molnar Cc: Jiang Liu , Benjamin Herrenschmidt , Thomas Gleixner , Grant Likely , Ingo Molnar , "H. Peter Anvin" , "Rafael J. Wysocki" , Bjorn Helgaas , Randy Dunlap , Yinghai Lu , Konrad Rzeszutek Wilk , Andrew Morton , "Luck, Tony" , Joerg Roedel , "Gortmaker, Paul (Wind River)" , Greg Kroah-Hartman , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-acpi@vger.kernel.org" , alek.du@i On Sun, Jun 22, 2014 at 10:39:46PM +0800, Feng Tang wrote: > Hi, >=20 > On Sun, Jun 22, 2014 at 04:42:27PM +0800, Ingo Molnar wrote: > >=20 > > JFYI, with these patches applied x86 allyes32config fails with: > >=20 > > arch/x86/platform/intel-mid/device_libs/platform_wdt.c:45:3: erro= r: implicit declaration of function =E2=80=98io_apic_set_pci_routing=E2= =80=99=20 >=20 > In some intel-mid platforms (Medfield/Merrifield etc), the IOAPIC > may have more than 80 pins, and some devices like a i2c based touch > screen has its interrupt line directly connected to IOAPIC (this > platform_wdt.c here should be the same case). >=20 > Since these devices are not PCI device or ACPI device, they can't > use the general PCI/ACPI xxx_enable_dev APIs which implicitly set > up the ioapic entry, but use this "io_apic_set_pci_routing" > directly. Just quickly read Jiang's patch set, guess these driver should be ok by using Jiang's new cleaner API "mp_set_gsi_attr()" to replace these io_apic_set_pci_routing(). Thanks, =46eng -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752056AbaFVPEg (ORCPT ); Sun, 22 Jun 2014 11:04:36 -0400 Received: from mga09.intel.com ([134.134.136.24]:37618 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487AbaFVPEe (ORCPT ); Sun, 22 Jun 2014 11:04:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,524,1400050800"; d="scan'208";a="532315396" Date: Sun, 22 Jun 2014 23:02:12 +0800 From: Feng Tang To: Ingo Molnar Cc: Jiang Liu , Benjamin Herrenschmidt , Thomas Gleixner , Grant Likely , Ingo Molnar , "H. Peter Anvin" , "Rafael J. Wysocki" , Bjorn Helgaas , Randy Dunlap , Yinghai Lu , Konrad Rzeszutek Wilk , Andrew Morton , "Luck, Tony" , Joerg Roedel , "Gortmaker, Paul (Wind River)" , Greg Kroah-Hartman , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-acpi@vger.kernel.org" , alek.du@intel.com, mark.gross@intel.com Subject: Re: [Patch V4 00/42] use irqdomain to dynamically allocate IRQ for IOAPIC Message-ID: <20140622150212.GB20551@feng-snb> References: <1402302011-23642-1-git-send-email-jiang.liu@linux.intel.com> <20140622084227.GA13974@gmail.com> <20140622143946.GA20551@feng-snb> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140622143946.GA20551@feng-snb> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 22, 2014 at 10:39:46PM +0800, Feng Tang wrote: > Hi, > > On Sun, Jun 22, 2014 at 04:42:27PM +0800, Ingo Molnar wrote: > > > > JFYI, with these patches applied x86 allyes32config fails with: > > > > arch/x86/platform/intel-mid/device_libs/platform_wdt.c:45:3: error: implicit declaration of function ‘io_apic_set_pci_routing’ > > In some intel-mid platforms (Medfield/Merrifield etc), the IOAPIC > may have more than 80 pins, and some devices like a i2c based touch > screen has its interrupt line directly connected to IOAPIC (this > platform_wdt.c here should be the same case). > > Since these devices are not PCI device or ACPI device, they can't > use the general PCI/ACPI xxx_enable_dev APIs which implicitly set > up the ioapic entry, but use this "io_apic_set_pci_routing" > directly. Just quickly read Jiang's patch set, guess these driver should be ok by using Jiang's new cleaner API "mp_set_gsi_attr()" to replace these io_apic_set_pci_routing(). Thanks, Feng