From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753545AbaFWSJv (ORCPT ); Mon, 23 Jun 2014 14:09:51 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:48536 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753470AbaFWSJu (ORCPT ); Mon, 23 Jun 2014 14:09:50 -0400 X-Sasl-enc: NyEfc6NItw6YtrWayPVVp0bj2b3r1bWpd+MbBQ8WxMVM 1403546988 Date: Mon, 23 Jun 2014 14:09:37 -0400 From: Greg KH To: Martin Peres Cc: Ilia Mirkin , kernel list , "dri-devel@lists.freedesktop.org" , Ben Skeggs , Pavel Machek Subject: Re: unparseable, undocumented /sys/class/drm/.../pstate Message-ID: <20140623180937.GB29494@kroah.com> References: <20140621180201.GA4621@amd.pavel.ucw.cz> <20140621194538.GA4903@kroah.com> <20140623160727.GA19557@kroah.com> <20140623163600.GB20939@kroah.com> <53A867DB.90604@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <53A867DB.90604@free.fr> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 23, 2014 at 07:46:03PM +0200, Martin Peres wrote: > Le 23/06/2014 18:40, Ilia Mirkin a écrit : > >On Mon, Jun 23, 2014 at 12:36 PM, Greg KH wrote: > >>On Mon, Jun 23, 2014 at 12:18:51PM -0400, Ilia Mirkin wrote: > >>A list of valid "values" that a file can be in is fine if you just then > >>write one value back to that file. That's the one exception, but a > >>minor one given the huge number of sysfs files. Other than that, if you > > > >Which is pretty much what the pstate file is. Would it make things > >better if we removed the descriptive info while leaving the pstate > >file in place? > > This means we should also create a new sysfs file per performance level too, > right? Is there another way for a driver to expose a list in sysfs? What exactly are you wanting to export to userspace? What will userspace do with this information? Why export anything at all? Start with defining that, and go from there. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: unparseable, undocumented /sys/class/drm/.../pstate Date: Mon, 23 Jun 2014 14:09:37 -0400 Message-ID: <20140623180937.GB29494@kroah.com> References: <20140621180201.GA4621@amd.pavel.ucw.cz> <20140621194538.GA4903@kroah.com> <20140623160727.GA19557@kroah.com> <20140623163600.GB20939@kroah.com> <53A867DB.90604@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by gabe.freedesktop.org (Postfix) with ESMTP id 191B76E46C for ; Mon, 23 Jun 2014 11:09:50 -0700 (PDT) Received: from compute4.internal (compute4.nyi.mail.srv.osa [10.202.2.44]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 1A74921560 for ; Mon, 23 Jun 2014 14:09:49 -0400 (EDT) Content-Disposition: inline In-Reply-To: <53A867DB.90604@free.fr> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Martin Peres Cc: Pavel Machek , "dri-devel@lists.freedesktop.org" , kernel list , Ben Skeggs List-Id: dri-devel@lists.freedesktop.org On Mon, Jun 23, 2014 at 07:46:03PM +0200, Martin Peres wrote: > Le 23/06/2014 18:40, Ilia Mirkin a =E9crit : > >On Mon, Jun 23, 2014 at 12:36 PM, Greg KH wrote: > >>On Mon, Jun 23, 2014 at 12:18:51PM -0400, Ilia Mirkin wrote: > >>A list of valid "values" that a file can be in is fine if you just then > >>write one value back to that file. That's the one exception, but a > >>minor one given the huge number of sysfs files. Other than that, if you > > > >Which is pretty much what the pstate file is. Would it make things > >better if we removed the descriptive info while leaving the pstate > >file in place? > = > This means we should also create a new sysfs file per performance level t= oo, > right? Is there another way for a driver to expose a list in sysfs? What exactly are you wanting to export to userspace? What will userspace do with this information? Why export anything at all? Start with defining that, and go from there. thanks, greg k-h