From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48404)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1X0AbB-000494-SF
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 10:24:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1X0Ab5-0007f0-O1
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 10:24:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:65452)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1X0Ab5-0007et-H5
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 10:24:19 -0400
Date: Thu, 26 Jun 2014 10:24:16 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20140626102416.5e91e2bd@redhat.com>
In-Reply-To: <53AC2BFB.1020003@redhat.com>
References: <1403073840-32603-1-git-send-email-pbonzini@redhat.com>
	<1403073840-32603-24-git-send-email-pbonzini@redhat.com>
	<87lhsjepbe.fsf@blackfin.pond.sub.org>
	<53AC2BFB.1020003@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2.1 23/36] qapi event: convert other
 BLOCK_JOB events
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Markus Armbruster <armbru@redhat.com>, wenchaoqemu@gmail.com, qemu-devel@nongnu.org

On Thu, 26 Jun 2014 16:19:39 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 26/06/2014 16:08, Markus Armbruster ha scritto:
> >
> > Suggests that
> >
> > * Before this patch, code disagreed with docs, and qemu-iotests/040
> >   matched the code.
> >
> > * After this patch, code matches docs, and qemu-iotests/040 matches
> >   neither.
> >
> > Please advise.
> 
> Code is always right. :)

Agreed. We have to fix everything to match the code prior to the
conversion.

Are you going to take a stab at it yourself?