From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49099)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1X0C2C-0006NI-Bp
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 11:56:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1X0C1u-0001NW-Tb
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 11:56:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:65274)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1X0C1u-0001Mp-Lx
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 11:56:06 -0400
Date: Thu, 26 Jun 2014 11:56:02 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20140626115602.4b0baa19@redhat.com>
In-Reply-To: <87simrbrgv.fsf@blackfin.pond.sub.org>
References: <1403073840-32603-1-git-send-email-pbonzini@redhat.com>
	<87simrbrgv.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2.1 00/36] Pending monitor patches for 2.1
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, wenchaoqemu@gmail.com

On Thu, 26 Jun 2014 17:50:08 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Paolo Bonzini <pbonzini@redhat.com> writes:
> 
> > This includes:
> >
> > - Max's dependency fixes for QAPI scripts
> >
> > - Wenchao's QAPI event series
> >
> > - my thread-safety fixes, rebased onto QAPI events
> 
> The QAPI event series messed up two out of three event types tested in
> qemu-iotests, if I count them correctly.

Let's fix 'em.

> 
> How can we gain confidence that we're not breaking half of the events
> not tested there, too?

Let's test 'em. It would be superb to add tests for them.

I tested most of them myself before applying the series, but it was a
manual test. I didn't check/test every single field of every single event.