From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50592)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1X0C6W-0001aE-CA
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 12:00:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1X0C6O-0003MF-P7
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 12:00:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:6696)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1X0C6N-0003Lo-WC
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 12:00:44 -0400
Date: Thu, 26 Jun 2014 12:00:41 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20140626120041.235da2f3@redhat.com>
In-Reply-To: <87tx77aciq.fsf@blackfin.pond.sub.org>
References: <1403073840-32603-1-git-send-email-pbonzini@redhat.com>
	<1403073840-32603-22-git-send-email-pbonzini@redhat.com>
	<87simrd6lu.fsf@blackfin.pond.sub.org>
	<53AC3F09.2070705@redhat.com>
	<87tx77aciq.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert
 BLOCK_IO_ERROR and BLOCK_JOB_ERROR
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, wenchaoqemu@gmail.com

On Thu, 26 Jun 2014 17:58:21 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Paolo Bonzini <pbonzini@redhat.com> writes:
>=20
> > Il 26/06/2014 17:37, Markus Armbruster ha scritto:
> >> Paolo Bonzini <pbonzini@redhat.com> writes:
> >>=20
> >>> From: Wenchao Xia <wenchaoqemu@gmail.com>
> >>>
> >>> Signed-off-by: Wenchao Xia <wenchaoqemu@gmail.com>
> >>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >>=20
> >> This broke tests/qemu-iotests/041.  Apparently, the BLOCK_JOB_ERROR
> >> event changed from
> >>=20
> >>     {'timestamp': {'seconds': 1403796871, 'microseconds': 446502},
> >>      'data': {'device': 'drive0',
> >
> > - bdrv_emit_qmp_error_event(job->bs, QEVENT_BLOCK_JOB_ERROR, action,
> > is_read);
> > +    qapi_event_send_block_job_error(bdrv_get_device_name(bs),
> >
> > Should have been job->bs.
>=20
> Will you post a patch, or would you like me to do that?

I was going to do it myself, but it would be great if you could do that.

>=20
> >>               'action': 'ignore',
> >>               'operation': 'write'},
> >>      'event': 'BLOCK_JOB_ERROR'}
> >>=20
> >> to
> >>=20
> >>     {'timestamp': {'seconds': 1403796674, 'microseconds': 63271},
> >>      'data': {'device': '',
> >>               'action': 'report',
> >
> > I suppose ignore vs. report is just from pasting two different sections?
>=20
> Could well be; it's almost time for Fu=C3=9Fball & Bier ;)
>=20