From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenzo Pieralisi Subject: Re: [PATCH v5 7/8] drivers: cpuidle: initialize Exynos driver through DT Date: Thu, 26 Jun 2014 16:16:01 +0100 Message-ID: <20140626151601.GB27364@e102568-lin.cambridge.arm.com> References: <1403705421-17597-1-git-send-email-lorenzo.pieralisi@arm.com> <1403705421-17597-8-git-send-email-lorenzo.pieralisi@arm.com> <5019714.S4WTdsyrXS@amdc1032> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5019714.S4WTdsyrXS@amdc1032> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Bartlomiej Zolnierkiewicz Cc: Mark Rutland , Catalin Marinas , Tomasz Figa , Chander Kashyap , Kukjin Kim , Vincent Guittot , Nicolas Pitre , Daniel Lezcano , "linux-arm-kernel@lists.infradead.org" , "grant.likely@linaro.org" , Charles Garcia-Tobin , "devicetree@vger.kernel.org" , Kevin Hilman , "linux-pm@vger.kernel.org" , Sebastian Capella , Mark Brown , Antti Miettinen , Paul Walmsley , Peter De Schrijver , Stephen Boyd , Amit List-Id: devicetree@vger.kernel.org On Wed, Jun 25, 2014 at 04:23:38PM +0100, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Wednesday, June 25, 2014 03:10:20 PM Lorenzo Pieralisi wrote: > > With the introduction of DT based idle states, CPUidle drivers for > > ARM can now initialize idle states data through properties in the device > > tree. > > > > This patch adds code to the Exynos CPUidle driver to dynamically > > initialize idle states data through the updated device tree source > > files. > > > > Cc: Kukjin Kim > > Cc: Tomasz Figa > > Signed-off-by: Lorenzo Pieralisi > > --- > > Compile tested, I am not sure I patched the right dts files, please check. > > cpuidle-exynos driver is currently working properly in deeper cpuidle > mode (AFTR) on Exynos4210 and Exynos5250 (please also see the following > patch from Tomasz Figa: [1]). There is ongoing work to AFTR mode work > also on Exynos4x12 and Exynos3250 but it is not complete yet. Exynos5410 > OTOH should probably use the generic big little cpuidle driver (this SoC > is similar to Exynos5420 one for which Chander Kashyap has developed > cpuidle-big_little support [2]). > > Making long story short, I think that your patch should depend on patch > [1] and update only exynos4210.dtsi and exynos5250.dtsi. Also for your > patch #6 there needs to be some coordination with merging of Chander's > patchset ([2]). Ok, thank you for the info, I will coordinate with Tomasz and Chander then. Lorenzo > [1] http://www.spinics.net/lists/arm-kernel/msg341023.html > [2] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg664470.html > > > .../devicetree/bindings/arm/exynos/idle-states.txt | 27 ++++++++++++++++++++ > > arch/arm/boot/dts/exynos3250.dtsi | 16 ++++++++++++ > > arch/arm/boot/dts/exynos5250.dtsi | 15 +++++++++++ > > arch/arm/boot/dts/exynos5410.dtsi | 17 +++++++++++++ > > drivers/cpuidle/Kconfig.arm | 1 + > > drivers/cpuidle/cpuidle-exynos.c | 29 +++++++++++++--------- > > 6 files changed, 93 insertions(+), 12 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/arm/exynos/idle-states.txt > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi) Date: Thu, 26 Jun 2014 16:16:01 +0100 Subject: [PATCH v5 7/8] drivers: cpuidle: initialize Exynos driver through DT In-Reply-To: <5019714.S4WTdsyrXS@amdc1032> References: <1403705421-17597-1-git-send-email-lorenzo.pieralisi@arm.com> <1403705421-17597-8-git-send-email-lorenzo.pieralisi@arm.com> <5019714.S4WTdsyrXS@amdc1032> Message-ID: <20140626151601.GB27364@e102568-lin.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jun 25, 2014 at 04:23:38PM +0100, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Wednesday, June 25, 2014 03:10:20 PM Lorenzo Pieralisi wrote: > > With the introduction of DT based idle states, CPUidle drivers for > > ARM can now initialize idle states data through properties in the device > > tree. > > > > This patch adds code to the Exynos CPUidle driver to dynamically > > initialize idle states data through the updated device tree source > > files. > > > > Cc: Kukjin Kim > > Cc: Tomasz Figa > > Signed-off-by: Lorenzo Pieralisi > > --- > > Compile tested, I am not sure I patched the right dts files, please check. > > cpuidle-exynos driver is currently working properly in deeper cpuidle > mode (AFTR) on Exynos4210 and Exynos5250 (please also see the following > patch from Tomasz Figa: [1]). There is ongoing work to AFTR mode work > also on Exynos4x12 and Exynos3250 but it is not complete yet. Exynos5410 > OTOH should probably use the generic big little cpuidle driver (this SoC > is similar to Exynos5420 one for which Chander Kashyap has developed > cpuidle-big_little support [2]). > > Making long story short, I think that your patch should depend on patch > [1] and update only exynos4210.dtsi and exynos5250.dtsi. Also for your > patch #6 there needs to be some coordination with merging of Chander's > patchset ([2]). Ok, thank you for the info, I will coordinate with Tomasz and Chander then. Lorenzo > [1] http://www.spinics.net/lists/arm-kernel/msg341023.html > [2] https://www.mail-archive.com/linux-kernel at vger.kernel.org/msg664470.html > > > .../devicetree/bindings/arm/exynos/idle-states.txt | 27 ++++++++++++++++++++ > > arch/arm/boot/dts/exynos3250.dtsi | 16 ++++++++++++ > > arch/arm/boot/dts/exynos5250.dtsi | 15 +++++++++++ > > arch/arm/boot/dts/exynos5410.dtsi | 17 +++++++++++++ > > drivers/cpuidle/Kconfig.arm | 1 + > > drivers/cpuidle/cpuidle-exynos.c | 29 +++++++++++++--------- > > 6 files changed, 93 insertions(+), 12 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/arm/exynos/idle-states.txt > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >