Re: [PATCH v2] btrfs-progs: Add uninstall targets to Makefiles.

[David Sterba <dsterba@suse.cz>]

On Wed, Jun 25, 2014 at 09:40:40PM +0200, Nils Steinger wrote:
> On Mon, Jun 23, 2014 at 05:04:42PM +0200, David Sterba wrote:
> > On Mon, Jun 23, 2014 at 04:23:48AM +0200, Nils Steinger wrote:
> > > +	rmdir -p --ignore-fail-on-non-empty $(DESTDIR)$(man8dir)
> > 
> > > +	rmdir -p --ignore-fail-on-non-empty $(DESTDIR)$(libdir)
> > 
> > > +	rmdir -p --ignore-fail-on-non-empty $(DESTDIR)$(bindir)
> > 
> > I don't think it's right to remove the systemwide directories: bindir,
> > libdir and man8dir. There rest are btrfs subdirs (eg. incdir), that's
> > fine.
> 
> On my system, man8dir didn't exist prior to the installation, so I
> thought it would be reasonable to have the uninstallation routine remove
> it.

According to the FHS [1] the manX directories do not have to exsit, so
this part shall stay.

> bindir and libdir will exist by default on most systems, so that's a
> different case…
> So, should we really keep the directories around, even if they were
> created by the installation and are now empty (if they aren't, they
> won't be removed anyway)?

But we don't track if the directories were created by the installation
or not.  Normally the directories would exist anyway (/usr or /usr/local
as prefix) and are expected to exist at the locations. Installation to
arbitraty directory works, but managing the directories is IMO up to the
user.

So are you ok with keeping bindir and libdir only (ie. removing only
man8dir)?

Thanks.

[1] http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREMANMANUALPAGES
and then note #32