From: Kevin Wolf <kwolf@redhat.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: famz@redhat.com, qemu-trivial@nongnu.org,
Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH trivial v2] block.c: Add return value for bdrv_append_temp_snapshot() to avoid incorrect failure processing issue
Date: Fri, 27 Jun 2014 19:21:57 +0200 [thread overview]
Message-ID: <20140627172157.GL5223@noname.redhat.com> (raw)
In-Reply-To: <53A84797.9040304@gmail.com>
Am 23.06.2014 um 17:28 hat Chen Gang geschrieben:
> When failure occurs, 'ret' need be set, or may return 0 to indicate success.
> And error_propagate() also need be called only one time within a function.
>
> It is abnormal to prevent bdrv_append_temp_snapshot() return value but still
> set errp when error occurs -- although it contents return value internally.
>
> So let bdrv_append_temp_snapshot() internal return value outside, and let
> all things normal, then fix the issue too.
>
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2014-06-27 18:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 15:28 [Qemu-devel] [PATCH trivial v2] block.c: Add return value for bdrv_append_temp_snapshot() to avoid incorrect failure processing issue Chen Gang
2014-06-24 2:25 ` Fam Zheng
2014-06-24 2:32 ` Chen Gang
2014-06-24 10:46 ` Kevin Wolf
2014-06-24 11:01 ` Markus Armbruster
2014-06-24 16:00 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-06-25 22:13 ` Chen Gang
2014-06-27 11:50 ` [Qemu-devel] " Stefan Hajnoczi
2014-06-27 17:21 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140627172157.GL5223@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=famz@redhat.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.