From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2 3/6] xfs: add xfs_mount sysfs kobject
Date: Sat, 28 Jun 2014 10:56:17 +1000 [thread overview]
Message-ID: <20140628005617.GB9508@dastard> (raw)
In-Reply-To: <1403870821-20143-4-git-send-email-bfoster@redhat.com>
On Fri, Jun 27, 2014 at 08:06:58AM -0400, Brian Foster wrote:
> Embed a base kobject into xfs_mount. This creates a kobject associated
> with each XFS mount and a subdirectory in sysfs with the name of the
> filesystem. The subdirectory lifecycle matches that of the mount. Also
> add the new xfs_sysfs.[c,h] source files with some XFS sysfs
> infrastructure to facilitate attribute creation.
>
> Note that there are currently no attributes exported as part of the
> xfs_mount kobject. It exists solely to serve as a per-mount container
> for child objects.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
One minor thing I can clean up directly:
> +static inline int
> +xfs_sysfs_init(
> + struct xfs_kobj *kobj,
> + struct kobj_type *ktype,
> + struct xfs_kobj *p_kobj,
^^^^^^
parent_kobj would be better - that looks too much like hungarian
notation... :)
Other than that,
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-06-28 0:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 12:06 [PATCH v2 0/6] xfs sysfs support Brian Foster
2014-06-27 12:06 ` [PATCH v2 1/6] xfs: fix a couple error sequence jumps in xfs_mountfs() Brian Foster
2014-06-27 12:06 ` [PATCH v2 2/6] xfs: add a sysfs kset Brian Foster
2014-06-27 12:06 ` [PATCH v2 3/6] xfs: add xfs_mount sysfs kobject Brian Foster
2014-06-28 0:56 ` Dave Chinner [this message]
2014-06-27 12:06 ` [PATCH v2 4/6] xfs: add xlog sysfs kobject and attribute handlers Brian Foster
2014-07-10 23:33 ` Dave Chinner
2014-06-27 12:07 ` [PATCH v2 5/6] xfs: add log attributes for log lsn and grant head data Brian Foster
2014-06-27 12:07 ` [PATCH v2 6/6] xfs: document log sysfs attributes in testing ABI Brian Foster
2014-07-10 23:32 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140628005617.GB9508@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.