From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45961)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1X1Gtk-0003EP-QO
	for qemu-devel@nongnu.org; Sun, 29 Jun 2014 11:20:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1X1Gtg-0006hk-6U
	for qemu-devel@nongnu.org; Sun, 29 Jun 2014 11:20:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50691)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1X1Gtf-0006gW-Um
	for qemu-devel@nongnu.org; Sun, 29 Jun 2014 11:20:04 -0400
Date: Sun, 29 Jun 2014 18:20:22 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140629152022.GC29448@redhat.com>
References: <1403687054-13682-1-git-send-email-hutao@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1403687054-13682-1-git-send-email-hutao@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH] numa: check for busy memory backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org, Yasunori Goto <y-goto@jp.fujitsu.com>

On Wed, Jun 25, 2014 at 05:04:14PM +0800, Hu Tao wrote:
> ..to prevent one memory backend from being used by more than one numa
> node.

Thanks, but please always make the msg content self-contained
so it can be understood without the subject.
E.g. here, just drop "..to".

Are you sure we want this? Is there a chance sharing a backend
can be useful?

Igor, what's your take?

> 
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
>  numa.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/numa.c b/numa.c
> index e471afe..6c1c554 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -279,6 +279,13 @@ void memory_region_allocate_system_memory(MemoryRegion *mr, Object *owner,
>              exit(1);
>          }
>  
> +        if (memory_region_is_mapped(seg)) {
> +            char *path = object_get_canonical_path_component(OBJECT(backend));
> +            error_report("memory backend %s is busy", path);
> +            g_free(path);
> +            exit(1);
> +        }
> +
>          memory_region_add_subregion(mr, addr, seg);
>          vmstate_register_ram_global(seg);
>          addr += size;
> -- 
> 1.9.3